[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416)
|
From: |
Darshit Shah |
|
Subject: |
Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416) |
|
Date: |
Fri, 22 Mar 2019 07:29:41 +0000 |
Nice work! Code looks good! A few nitpicks which you can easily resolve.
Please rework all of this into a single commit, rebase and force push to this
branch. Also, please use the right format for the commit messages. See commit
7537c9fd86875193c283757a0ff8e53a2acd8ae0 for an example of how they should be
formatted.
We are now waiting on the processing of your copyright assignment to merge this.
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget2/merge_requests/416#note_153160379
You're receiving this email because of your account on gitlab.com.
- [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Kumar Mallikarjuna, 2019/03/20
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Tim Rühsen, 2019/03/21
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Tim Rühsen, 2019/03/21
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Tim Rühsen, 2019/03/21
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Kumar Mallikarjuna, 2019/03/21
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Kumar Mallikarjuna, 2019/03/21
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Tim Rühsen, 2019/03/21
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Kumar Mallikarjuna, 2019/03/22
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Darshit Shah, 2019/03/22
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416),
Darshit Shah <=
- Message not available
- Message not available
- Message not available
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Kumar Mallikarjuna, 2019/03/22
- Message not available
- Message not available
- Message not available
- Re: [Wget-dev] wget2 | Fix for -p -nc Bug (!416), Kumar Mallikarjuna, 2019/03/22