Re: [Wget-dev] scripts under /benchmarks

[G_Gold]

Darshit,
Thank you for the clear reply - I will look into this more then,
and DM you on IRC for more clarifications/questions, when needed. 

Guy

On Wed,Sep 05 01:30:PM, Darshit Shah wrote:
> Hi,
> 
> I am indeed quite interested in seeing the benchmark scripts become mature so
> that we can use them on a regular basis. However, this requires quite some
> work. If you like working with shell scripts (Bash, Python), then I think this
> is a great item for you to work on. I will keep an eye out for any MRs you 
> come
> up with and can answer any questions you have.
> 
> First, about trying to run the scripts...
> As I've mentioned previously, these were written once over a year ago and no
> one has looked at them again. If you have a problem getting them to work, one
> of the easier solutions would be for you to contact me on IRC. I'm darnir and
> you can fine me on #wget on Freenode. Instant communication can be a lot 
> faster
> at debugging these issues.
> 
> It seems like there may have been a small misunderstanding about the directory
> structure required to run the benchmark script. This is the expected directory
> structure:
> 
> .
> ├── curl
> │   └── src
> │             └── curl
> ├── wget
> │   └── src
> │       └── wget
> └── wget2
>     ├── benchmarks
>       │   └── benchmark.sh
>     └── src
>         └── wget2_noinstall
> 
> Now, if you run the benchmark.sh script, you should see some output. Namely,
> the wget, curl and wget2 commands that are being executed. Once the script
> completes, you should see the `*.data` and `*.svg` files as Tim mentioned. If
> you don't see that, please try adding a `set -x` to the beginning of the 
> script
> and try to debug what is happening.
> 
> Once you have the benchmark script running, my suggestion would be to first
> modify the script so that it doesn't need to depend on such a directory
> structure. By default it should try to clone and build cURL and Wget1.x within
> it's directory itself. However, support for a command line option that allows
> you to provide a path to the executables would also be nice. Once that is 
> done,
> we can discuss the various ways in which the benchmarking can be improved.
> 
> * G_Gold <address@hidden> [180903 14:55]:
> > Hi,
> > Can you think of a reason as to why my outcome differs thanyours ? I 
> > believe I
> > have the correct packages installed (gnuplot, etc) , however I
> > don't seem to end up with the same output files . 
> > 
> > If this is not an urgent matter to handle, and there are other
> > places I may be helpful with, please let me know, :)
> > 
> > Guy
> > 
> > On Sun,Aug 05 08:07:PM, G_Gold wrote:
> > > odd..
> > > the last three commands running seem like the everything's fine,
> > > but no actual output files are being written :-|
> > > 
> > > Am I missing something obvious ?
> > > 
> > > 
> > > + /home/guy/wget2/benchmarks/../../wget/src/wget -q --no-config 
> > > -O/dev/null 'https://www.example.com/?test=1'
> > > + /home/guy/wget2/benchmarks/../src/wget2_noinstall -q --no-config 
> > > -O/dev/null 'https://www.example.com/?test=1'
> > > + /home/guy/wget2/benchmarks/../../curl/src/curl -s -o/dev/null 
> > > --cert-status 'https://www.example.com/?test=1'
> > > 
> > > On Sun,Aug 05 12:15:PM, Tim R�hsen wrote:
> > > > You should also see
> > > > -rw-r--r--  1 tim tim   600 Jul 31 14:26 wget_http1.data
> > > > -rw-r--r--  1 tim tim   600 Jul 31 14:26 wget2_http1.data
> > > > -rw-r--r--  1 tim tim   600 Jul 31 14:26 curl_http1.data
> > > > -rw-r--r--  1 tim tim   601 Jul 31 14:27 wget_http2.data
> > > > -rw-r--r--  1 tim tim   600 Jul 31 14:27 wget2_http2.data
> > > > -rw-r--r--  1 tim tim   600 Jul 31 14:28 curl_http2.data
> > > > -rw-r--r--  1 tim tim 22659 Jul 31 14:28 http1.svg
> > > > -rw-r--r--  1 tim tim 23610 Jul 31 14:28 http2.svg
> > > > 
> > > > If you don't see them, something is wrong. Try with 'bash -x
> > > > ./benchmark.sh'.
> > > > 
> > > > 
> > > > On 05.08.2018 00:20, G_Gold wrote:
> > > > > Hi,
> > > > > the benchmark.sh file is the newest modified one :-|
> > > > > 
> > > > > address@hidden:~/wget2/benchmarks$ ls -lt
> > > > > 
> > > > > -rwxrwxr-x 1 guy guy 3025 Aug  4 16:38 benchmark.sh
> > > > > -rwxrwxr-x 1 guy guy 2146 Jul 31 20:11 bench_https_http1
> > > > > -rwxrwxr-x 1 guy guy 2131 Jul 31 20:11 bench_https_http2
> > > > > -rw-rw-r-- 1 guy guy  141 Jul 31 20:11 README
> > > > > 
> > > > > On Sat,Aug 04 11:57:PM, Tim R�hsen wrote:
> > > > >> After running benchmark.sh, didn't you see any new files in the
> > > > >> directory ? Check the times...
> > > > >>
> > > > >> On 04.08.2018 22:45, G_Gold wrote:
> > > > >>> Thank you, 
> > > > >>> After placing and building wget and curl alongside with wget2,
> > > > >>> the benchmark.sh script exits w/o error. 
> > > > >>>
> > > > >>> I didn't notice any output, are the scripts intended to
> > > > >>> run in background without output ? are they  supposed to use
> > > > >>> gnuplot for the output ?
> > > > >>>
> > > > >>> 66 cat <<EOF | gnuplot
> > > > >>> 67        set terminal svg
> > > > >>> 68        set output "$1.svg"
> > > > >>>
> > > > >>> thank you. 
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>> On Thu,Aug 02 11:50:AM, Darshit Shah wrote:
> > > > >>>> Aah! `wget2_noinstall` is not a directory, but rather the name of 
> > > > >>>> the binary
> > > > >>>> which will be used. You should be able to see it after you run 
> > > > >>>> `make` to
> > > > >>>> compile the wget2 sources.
> > > > >>>>
> > > > >>>>
> > > > >>>> * G_Gold <address@hidden> [180802 09:51]:
> > > > >>>>> Darshit,
> > > > >>>>> I was referring to the 'wget2_noinstall' directory, I'm not able
> > > > >>>>> to locate it, in either wget or wget2 build directories. 
> > > > >>>>>
> > > > >>>>> I'm sorry if I'm missing something very obvious :-)
> > > > >>>>>
> > > > >>>
> > > > >>
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > 
> > > 
> > > 
> > > 
> > > 
> > > -- 
> > > Guy Gold
> > > 
> > 
> > -- 
> > Guy Gold
> > 
> > 
> 
> -- 
> Thanking You,
> Darshit Shah
> PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6



-- 
Guy Gold