[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383)

From: Tim Rühsen
Subject: Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383)
Date: Fri, 31 Aug 2018 12:23:28 +0000

Your code was a bit over-complicated. Parsing strings in C is often ugly and 
bears some pitfalls easily overseen. That's why fuzzing / sanitizers / valgrind 
are so valuable tools. Fuzzing even generates data and checks for totally weird 
corner cases, while sanitizers + valgrind already need a very good code path 
coverage in the test suite.

I just simplified the 'escape' code, please have a look and compare with your 

Reply to this email directly or view it on GitLab: 
You're receiving this email because of your account on gitlab.com.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]