[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383)
From: |
Tim Rühsen |
Subject: |
Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383) |
Date: |
Fri, 31 Aug 2018 12:23:28 +0000 |
Your code was a bit over-complicated. Parsing strings in C is often ugly and
bears some pitfalls easily overseen. That's why fuzzing / sanitizers / valgrind
are so valuable tools. Fuzzing even generates data and checks for totally weird
corner cases, while sanitizers + valgrind already need a very good code path
coverage in the test suite.
I just simplified the 'escape' code, please have a look and compare with your
code.
--
Reply to this email directly or view it on GitLab:
https://gitlab.com/gnuwget/wget2/merge_requests/383#note_98125665
You're receiving this email because of your account on gitlab.com.
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), (continued)
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/29
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/29
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/30
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), Tim Rühsen, 2018/08/30
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), Tim Rühsen, 2018/08/30
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), Tim Rühsen, 2018/08/30
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/30
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/30
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), Tim Rühsen, 2018/08/31
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/31
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383),
Tim Rühsen <=
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/31
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), Tim Rühsen, 2018/08/31
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/31
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/31
- Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383), DalmeGNU, 2018/08/31