wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | Refined commit-check (!375)


From: Darshit Shah
Subject: Re: [Wget-dev] wget2 | Refined commit-check (!375)
Date: Fri, 04 May 2018 08:37:07 +0000

Darshit Shah commented on a discussion on contrib/commit-check:

>  
>  AUTHOR=$(git log -n1 --format='%aN')
>  EMAIL=$(git log -n1 --format='%aE')
> -EMAIL_PARSE=$(echo "$EMAIL" | sed 's/@/ \\[at\\] /g')
> +EMAIL_PARSE=$(echo "$EMAIL" | sed 's/@/ [at] /g')
> +EMAIL_PARSE_PAT=$(echo "$EMAIL_PARSE" | sed 's/\[/\\[/g;s/\]/\\]/g')

Given how this is not really a user facing script, it is purely for admin / 
devel purposes, I am fine with keeping it as-is. Less code => less maintenance.

A little escaping is seen in the output, I'm fine with it since it reduces the 
complexity of the script.

---
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/375#note_71580256
You're receiving this email because of your account on gitlab.com.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]