Re: [vile] vile-9.6k.patch.gz

[Thomas Dickey]

On Mon, Apr 14, 2008 at 06:42:35PM +0200, Paul van Tilburg wrote:
> On Sat, Apr 12, 2008 at 09:04:28AM -0400, Thomas Dickey wrote:
> > On Sat, 12 Apr 2008, Paul van Tilburg wrote:
> >> On Thu, Apr 10, 2008 at 08:52:47PM -0400, Thomas Dickey wrote:
> >>>  patch by Thomas E. Dickey <address@hidden>
> >>>   + update list of filters in doc/config.doc
> >>>   + improve locale initialization, checking if there is no installed
> >>>     narrow locale corresponding to the given (wide) locale.  In that
> >>>     case, default to either ISO-8859-1 or ASCII, depending on whether
> >>>     there was actually a wide locale whose encoding is UTF-8 or
> >>>     ISO-8859-1, or neither (report by Paul Van Tilburg).
> >>
> >> Works great! Thanks!
> >> Uploading this to Debian Sid. :)
> >
> > no problem - let's see if this looks stable enough for 9.7
> 
> Actually... there is one thing I'd like to discuss.
> If file-encoding is set to auto, it will inspect the buffer to decide
> what to do which seems to default to '8bit' to my systems (inspecting
> $encoding) when editting an empty/new file.
> It would IMO be more sane to set the default based on the locale.
> I have set LC_CTYPE to an UTF-8 locale exactly for that purpose.
> If this is done, this still works for editting latin1/latin9 files
> or ASCII files. 

hmm - it's a little more complicated than that (I've made some changes
which seem to work, will be testing...).  For _reading_ a file, the
auto-detection is actually needed, I think, to avoid reading a latin1
file as utf-8 (it would tend to be illegal coding).

For _writing_ a new buffer, the locale is more reliable, since vile's
collecting all of the information on that.

So what I've implemented in the past couple of days is a new setting
for file-encoding, "locale", and made that the default.  The existing
"auto" setting tells it to use only its guess, while "locale" tells it
to use the locale-settings for new files.  The other values are still
used to tell it exactly what encoding to use.

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature