vgabios-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Vgabios-developers] [PATCH] Ensure PCIR is aligned to 4 bytes


From: Brad Smith
Subject: Re: [Vgabios-developers] [PATCH] Ensure PCIR is aligned to 4 bytes
Date: Thu, 12 Sep 2013 20:05:05 -0400
User-agent: Mozilla/5.0 (Macintosh; PPC Mac OS X 10.5; rv:17.0) Gecko/20130812 Thunderbird/17.0.8 TenFourFox/Debugging

On 20/01/13 1:12 PM, David Woodhouse wrote:
The PCI Firmware Specification apparently requires that the PCI Data
Structure be DWORD-aligned. The implementation in OVMF also requires
this, so vgabios ROMs don't work there. With this fixed, I can now
initialise the VGA ROM from EFI, and EFI can display using INT 10h
services.

--- vgabios-0.6c/vgabios.c.orig 2013-01-20 11:33:36.138548472 -0600
+++ vgabios-0.6c/vgabios.c      2013-01-20 11:36:26.060270163 -0600
@@ -204,6 +204,7 @@ vgabios_website:
  .byte 0x00

  #ifdef PCIBIOS
+.align 4 // DWORD alignment required by PCI Firmware Specification
  vgabios_pci_data:
  .ascii "PCIR"
  #ifdef CIRRUS

We have had this in the OpenBSD port of QEMU for awhile now. Is it possible to have this reviewed and commited?

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]