Re: Error handling

[Kaloian Doganov]

Yavor Doganov <address@hidden> writes:

    Sorry, I just have difficulty reading patches with long lines (BTW,
    please don't introduce them in new code, we will have to reformat
    them anyway).

OK, I'll fix this.

    but you must do

     || (sleep ...; touch ...; exit 1)

    otherwise make will continue without any problem.

Ah, right.  Fixed.

    Typo in $(web_addr).

Fixed.

    Please use the standard format for the If statement, basically how
    C-c TAB formats it in Shell-script mode.  It is easier to read that
    way and it's established usage.

I find the so called "standard format" of If too verbose for such
one-liner.  But your point led me to notice that If should not be used
here at all.  The same semantic should be expressed more cleanly this
way:

    [ $# -gt 0 ] || usage

I'll review the new scripts and will change them appropriately.

    Why the double brackets are necessary?

They are not.  I always confuse those countless ways to write shell
expressions.

    I assume you have tested well all of this, so please commit with the
    discussed changes.

Well, apparently it isn't tested enough since you have found a bug. :-)