Re: VCS=(yes|always)

[Yavor Doganov]

On Sun, Jan 27, 2008 at 09:54:30AM +0200, Yavor Doganov wrote:
> Калоян Доганов wrote:
> > +ifeq (yes,$(subst always,yes,$(VCS)))
> 
> Furthermore, this will trigger the rule when VCS=yes which is useless 
> and slow.

Err, sorry -- of course this is not true.

> > +     ($(CVS) $(CVSOPTS) add $$file ; exit 0) ; done
> 
> Since CVSOPTS will always expand to the empty string here, no matter
> what, I still don't see the point.  The conditional for this target is
> evaluated at the beginning, when make reads the makefile, and since it
> is always false when VCS is not "yes" or "always" (with your patch),
> the variables are not assigned values at all.  This rule is a black
> hole for make when the conditional is not met.  So you may as well
> substitute it with the empty string, like it is now.

This is still true with VCS=always.  I don't see why we should use an 
extra variable when the only case in practice will be having that 
variable expand to the empty string.  Perhaps the only reason is making 
the makefile easier to read by humans -- but this only obfuscates it 
further.