[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Clean up Tramp version check
|
From: |
Nicholas Drozd |
|
Subject: |
Re: [PATCH] Clean up Tramp version check |
|
Date: |
Sun, 12 Jul 2020 14:54:57 -0500 |
> Thanks. However,
>
> > + (let ((tramp-minimum-emacs-version "30.1"))
> > + (should-error (tramp-check-version))))
>
> this does not work as expected. What is this check good for? I
> understand your intention, but do we need to test this case?
That test has already justified its existence, for it has revealed a
flaw in the implementation! TRAMP_EMACS_REQUIRED_VERSION was getting
substituted in two separate places, so tramp-check-version wasn't
checking against tramp-minimum-emacs-version, but rather a hardcoded
value. I've attached a new version of the patch. Hopefully this one is
right.
0001-Clean-up-Tramp-version-check.patch
Description: Text Data