[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [tpop3d-discuss]pure virtual tpop3d authentication patch
From: |
Kevin Bonner |
Subject: |
Re: [tpop3d-discuss]pure virtual tpop3d authentication patch |
Date: |
Fri, 2 Apr 2004 20:49:51 -0500 |
User-agent: |
KMail/1.5.4 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Friday 02 April 2004 05:27, Markus Lidel wrote:
> if you are using mysql or perl to authenticate a user, and you don't
> have an user in /etc/passwd, the user won't authenticate at all, because
> the getpwuid() call fails. So here is a patch, witch allows the
> authentication of a user with only mysql or perl.
There are benefits from the changes, such as no getpwuid calls if it's
configured a certain way, but in the worst case the getpwuid function would
be called twice instead of only once.
A problem I see with the patch is in the auth_mysql_new_apop function. If I
select only 4 rows and have not set the auth-mysql-mail-group config option,
the gid will never be set. The auth_mysql_new_user_pass function would have
the same problem.
Kevin Bonner
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQFAbhg//9i/ml3OBYMRAn6mAKCd+5gbYaZePfFERaEArP8OKpIV4ACfa5xY
jLfshqRhfyKcOze2tIMywbM=
=Cz/M
-----END PGP SIGNATURE-----