|
From: | Yann GROSSEL |
Subject: | [tpop3d-discuss] A few patches |
Date: | Mon, 14 Jul 2003 23:23:05 +0200 |
Hello Here are a few small patches I've done this week-end. They are against the current CVS repository. Please tell me what you think of them. configure.in.diff: - makes the configure script abort with an error message if no authentication driver is enabled - always detects if libcrypt is needed no matter what authentication drivers are selected (password.c uses the crypt() function in check_password() and it is always compiled in) main.c.diff: 'configfile' was missing in one of the log_print() calls tpop3d.conf.5.diff: fixes a few typos auth_flatfile.c.diff: this one fixes a bug that made read_user_passwd() return the pwhash of the last line of the flat file if the localpart supplied was not found in the file. This allowed someone knowning the last password in the file to log in with any (non existent) username password.c.diff: this one fixes two bugs in the check_password() function : - the default scheme was used to check the hash even if a different scheme was specified in the hash (for example it prevented the use of {md5} hashes in flat files, because {crypt} was always checked first and of course the check always failed) - the check against md5 hash was inversed, allowing users to log in with any password but the right one connection.c.diff: tpop3d crashed when the user issued a 'TOP' command on a empty mailbox or message (OK, empty mailboxes or messages should never happen, but if we can make tpop3d harder to crash even in unexpected situations...) warnings.diff: removes a few warnings (mainly "missing braces around initializer") (one warning remains at listener.c:59 - I think the alloc_struct macro should be fixed but I don't know the right fix to apply) -- Olrick
configure.in.diff
Description: Text document
main.c.diff
Description: Text document
tpop3d.conf.5.diff
Description: Text document
auth_flatfile.c.diff
Description: Text document
password.c.diff
Description: Text document
connection.c.diff
Description: Text document
warnings.diff
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |