texinfo-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[no subject]


From: Patrice Dumas
Date: Fri, 19 Apr 2024 06:20:52 -0400 (EDT)

branch: master
commit 863ee064b20453c2de8f2bf12a1f3a9a9cebe03f
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Thu Apr 18 22:27:17 2024 +0200

    * tp/Texinfo/XS/convert/convert_html.c: remove TODO already in
    Texinfo/Convert/HTML.pm.
    
    * tp/Texinfo/Convert/HTML.pm (_html_convert_convert)
    (_html_convert_output): change TODOs to NOTEs.
---
 ChangeLog                            |  8 ++++++++
 tp/Texinfo/Convert/HTML.pm           | 14 ++++++--------
 tp/Texinfo/XS/convert/convert_html.c |  7 -------
 3 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0c3011f921..e16ebd483e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2024-04-18  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/convert/convert_html.c: remove TODO already in
+       Texinfo/Convert/HTML.pm.
+
+       * tp/Texinfo/Convert/HTML.pm (_html_convert_convert)
+       (_html_convert_output): change TODOs to NOTEs.
+
 2024-04-18  Patrice Dumas  <pertusus@free.fr>
 
        * tp/init/html32.pm (html32_convert_tab_command): move code around,
diff --git a/tp/Texinfo/Convert/HTML.pm b/tp/Texinfo/Convert/HTML.pm
index ec71b59a2b..f314967881 100644
--- a/tp/Texinfo/Convert/HTML.pm
+++ b/tp/Texinfo/Convert/HTML.pm
@@ -12057,9 +12057,8 @@ sub _html_convert_convert($$$$)
   $self->{'current_filename'} = '';
 
   my $unit_nr = 0;
-  # TODO there is no rule before the footnotes special element in
-  # case of separate footnotes in the default formatting style.
-  # Not sure if it is an issue.
+  # NOTE there is no rule before the footnotes special element in
+  # case of separate footnotes in this setting.
   foreach my $output_unit (@$output_units, @$special_units) {
     print STDERR "\nC UNIT $unit_nr\n" if ($self->get_conf('DEBUG'));
     my $output_unit_text = $self->convert_output_unit($output_unit,
@@ -12535,9 +12534,8 @@ sub _html_convert_output($$$$$$$$)
     $self->{'current_filename'} = $output_filename;
     my $body = '';
     my $unit_nr = 0;
-    # TODO there is no rule before the footnotes special element in
-    # case of separate footnotes in the default formatting style.
-    # Not sure if it is an issue.
+    # NOTE there is no rule before the footnotes special element in
+    # case of separate footnotes in this setting.
     foreach my $output_unit (@$output_units, @$special_units) {
       print STDERR "\nUNIT NO-PAGE $unit_nr\n" if ($self->get_conf('DEBUG'));
       my $output_unit_text
@@ -13048,8 +13046,8 @@ sub output($$)
   # Some information is not available yet.
   $self->_reset_info();
 
-  # TODO document that this stage handler is called with end of
-  # preamble documentlanguage.
+  # TODO document that this stage handler is called with end of preamble
+  # documentlanguage when it is certain that this will not change ever.
   my $init_status = $self->run_stage_handlers($document, 'init');
   unless ($init_status < $handler_fatal_error_level
           and $init_status > -$handler_fatal_error_level) {
diff --git a/tp/Texinfo/XS/convert/convert_html.c 
b/tp/Texinfo/XS/convert/convert_html.c
index abd927b009..450ca937be 100644
--- a/tp/Texinfo/XS/convert/convert_html.c
+++ b/tp/Texinfo/XS/convert/convert_html.c
@@ -14091,9 +14091,6 @@ convert_definfoenclose_type (CONVERTER *self, const 
enum element_type type,
                        const ELEMENT *element, const char *content,
                        TEXT *result)
 {
-  /* TODO add a span to mark the original command as a class?
-     Not to be done as long as definfoenclose is deprecated. */
-
   const char *begin = lookup_extra_string (element, "begin");
   const char *end = lookup_extra_string (element, "end");
 
@@ -15572,7 +15569,6 @@ default_format_special_body_about (CONVERTER *self,
 
       if (button->type == BST_direction)
         {
-         /* TODO strip FirstInFile from $button to get active icon file? */
           if (self->conf->ICONS.integer > 0
               && self->conf->ACTIVE_ICONS.icons->number > 0
               && self->conf->ACTIVE_ICONS.icons->list[direction]
@@ -18783,9 +18779,6 @@ html_convert_output (CONVERTER *self, const ELEMENT 
*root,
                          unit_nr, "UNIT NO-PAGE", "no-page output unit");
           unit_nr++;
         }
-      /* TODO there is no rule before the footnotes special element in
-         case of separate footnotes in the default formatting style.
-         Not sure if it is an issue. */
       if (special_units && special_units->number)
         {
           for (i = 0; i < special_units->number; i++)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]