[no subject]

[Patrice Dumas]

branch: master
commit 8598a363786630ca8f5e60c2201ad441ed2c6ec3
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Tue Apr 16 09:07:59 2024 +0200

    Changes in comments
---
 tp/Texinfo/Convert/Converter.pm |  3 ++-
 tp/Texinfo/Transformations.pm   | 12 ++++++++++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/tp/Texinfo/Convert/Converter.pm b/tp/Texinfo/Convert/Converter.pm
index 2caf9ceb43..05d2e61780 100644
--- a/tp/Texinfo/Convert/Converter.pm
+++ b/tp/Texinfo/Convert/Converter.pm
@@ -144,7 +144,8 @@ my %defaults = (
 my %common_converters_defaults = (
   # Following are set in the main program
   'language_config_dirs' => undef,
-  'converted_format'     => undef,
+  'converted_format'     => undef, # also in converter defaults, but
+                                   # in general set by the caller
   # can be different from the converted_format, for example, epub3
   # output format converted format is html.
   'output_format'        => undef,
diff --git a/tp/Texinfo/Transformations.pm b/tp/Texinfo/Transformations.pm
index ad540d1d77..7901f061c9 100644
--- a/tp/Texinfo/Transformations.pm
+++ b/tp/Texinfo/Transformations.pm
@@ -313,9 +313,17 @@ sub _new_node($$;$)
     # that is used to construct the node.
     # Also protect_first_parenthesis has no XS override, only
     # protect_first_parenthesis_in_targets.
-    # FIXME we could also rebuild the tree, after adding an override
-    # for protect_first_parenthesis?
     confess("BUG: _new_node: XS not supported");
+
+    # It could have been possible to rebuild the tree, after adding
+    # an override for protect_first_parenthesis.
+    # If XS is used, however, it is be much better to override all
+    # the functions calling the current function instead of trying
+    # to have it work through an interface because the function is
+    # mostly internal.  So, it is better to keep failing with XS.
+    #
+    # The issue arise because the current function is used in tests,
+    # this cannot work with XS (and tests are skipped).
   }
 
   # We protect for all the contexts, as the node name should be