branch master updated: * tp/Texinfo/XS/convert/ConvertXS.xs (html_prepare_units_directions_files): always return undef, as the return value is ignored if XS overrides are used for the conversion.

[Patrice Dumas]

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 22d5a87435 * tp/Texinfo/XS/convert/ConvertXS.xs 
(html_prepare_units_directions_files): always return undef, as the return value 
is ignored if XS overrides are used for the conversion.
22d5a87435 is described below

commit 22d5a8743589de777d068507e8770bddbb5e1afa
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Wed Mar 13 00:18:31 2024 +0100

    * tp/Texinfo/XS/convert/ConvertXS.xs
    (html_prepare_units_directions_files): always return undef, as the
    return value is ignored if XS overrides are used for the conversion.
---
 ChangeLog                                     | 6 ++++++
 tp/Texinfo/XS/convert/ConvertXS.xs            | 8 ++------
 tp/Texinfo/XS/convert/build_html_perl_state.c | 1 +
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c77d0f9259..f6a79fb3d8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-03-12  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/convert/ConvertXS.xs
+       (html_prepare_units_directions_files): always return undef, as the
+       return value is ignored if XS overrides are used for the conversion.
+
 2024-03-12  Gavin Smith <gavinsmith0123@gmail.com>
 
        * doc/texinfo.texi (@itemize):
diff --git a/tp/Texinfo/XS/convert/ConvertXS.xs 
b/tp/Texinfo/XS/convert/ConvertXS.xs
index 8c6eac90b4..b324956a6c 100644
--- a/tp/Texinfo/XS/convert/ConvertXS.xs
+++ b/tp/Texinfo/XS/convert/ConvertXS.xs
@@ -1932,12 +1932,10 @@ html_prepare_units_directions_files (SV *converter_in, 
SV *output_units_in, SV *
          const char *document_name = (char *)SvPVutf8_nolen($arg);
   PREINIT:
          CONVERTER *self = 0;
-         FILE_SOURCE_INFO_LIST *files_source_info = 0;
-         SV *files_source_info_sv = 0;
      CODE:
          self = get_sv_converter (converter_in,
                                   "html_prepare_units_directions_files");
-         files_source_info = html_prepare_units_directions_files (self,
+         html_prepare_units_directions_files (self,
                     output_file, destination_directory, output_filename,
                                  document_name);
 
@@ -1950,8 +1948,6 @@ html_prepare_units_directions_files (SV *converter_in, SV 
*output_units_in, SV *
              rebuild_output_units_list (associated_special_units_in,
                 self->output_units_descriptors[OUDT_associated_special_units]);
 
-             files_source_info_sv
-               = build_html_files_source_info (files_source_info);
              pass_html_global_units_directions (converter_in,
                                             self->global_units_directions,
                                             
self->special_units_direction_name);
@@ -1962,7 +1958,7 @@ html_prepare_units_directions_files (SV *converter_in, SV 
*output_units_in, SV *
              pass_output_unit_files (converter_in, &self->output_unit_files);
            }
 
-         RETVAL = files_source_info_sv;
+         RETVAL = newSV (0);
     OUTPUT:
          RETVAL
 
diff --git a/tp/Texinfo/XS/convert/build_html_perl_state.c 
b/tp/Texinfo/XS/convert/build_html_perl_state.c
index 1447134a3b..00d4b91924 100644
--- a/tp/Texinfo/XS/convert/build_html_perl_state.c
+++ b/tp/Texinfo/XS/convert/build_html_perl_state.c
@@ -84,6 +84,7 @@ build_html_target (const HTML_TARGET *html_target)
   return html_target_hv;
 }
 
+/* Currently unused */
 SV *
 build_html_files_source_info (const FILE_SOURCE_INFO_LIST *files_source_info)
 {