branch master updated: * tp/Texinfo/XS/main/manipulate_indices.c: add const.

[Patrice Dumas]

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new c5f8f9b054 * tp/Texinfo/XS/main/manipulate_indices.c: add const.
c5f8f9b054 is described below

commit c5f8f9b054d198cb0c81003c33a5e5b2a95c983a
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Fri Feb 23 17:14:00 2024 +0100

    * tp/Texinfo/XS/main/manipulate_indices.c: add const.
    
    Remove TODOs.
---
 ChangeLog                               | 6 ++++++
 tp/Texinfo/XS/main/get_perl_info.c      | 6 ++----
 tp/Texinfo/XS/main/manipulate_indices.c | 6 +++---
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1a7878cc15..a943199b89 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-02-23  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/main/manipulate_indices.c: add const.
+
+       Remove TODOs.
+
 2024-02-23  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/XS/main/manipulate_indices.c
diff --git a/tp/Texinfo/XS/main/get_perl_info.c 
b/tp/Texinfo/XS/main/get_perl_info.c
index c83c8cd43e..dcd1b2931a 100644
--- a/tp/Texinfo/XS/main/get_perl_info.c
+++ b/tp/Texinfo/XS/main/get_perl_info.c
@@ -1483,9 +1483,6 @@ find_index_entry_associated_hv (const INDEX_ENTRY 
*index_entry,
   return 0;
 }
 
-/* TODO nodedescription using the extra element_node and the
- * node extra node_description? */
-
 /* find C Texinfo tree element based on element_sv perl tree element.
    Both DOCUMENT_IN and CONVERTER are optional, but if there is no
    document coming from one or the other, elements will not be found.
@@ -1495,7 +1492,8 @@ find_index_entry_associated_hv (const INDEX_ENTRY 
*index_entry,
    OUTPUT_UNIT_DESCRIPTOR is optional, it should allow to find sectioning
    commands faster.
    Only for global commands, commands with indices, and sectioning root
-   commands */
+   commands.  More could be added if needed, for example nodedescription.
+ */
 const ELEMENT *
 find_element_from_sv (const CONVERTER *converter, const DOCUMENT *document_in,
                       const SV *element_sv, int output_units_descriptor)
diff --git a/tp/Texinfo/XS/main/manipulate_indices.c 
b/tp/Texinfo/XS/main/manipulate_indices.c
index 9af6ad1546..708175fdde 100644
--- a/tp/Texinfo/XS/main/manipulate_indices.c
+++ b/tp/Texinfo/XS/main/manipulate_indices.c
@@ -283,7 +283,7 @@ typedef struct INDEX_COLLATOR {
 } INDEX_COLLATOR;
 
 static BYTES_STRING *
-get_sort_key (INDEX_COLLATOR *collator, const char *sort_string)
+get_sort_key (const INDEX_COLLATOR *collator, const char *sort_string)
 {
   BYTES_STRING *sort_key;
   switch (collator->type)
@@ -615,7 +615,7 @@ setup_collator (int use_unicode_collation, const char 
*collation_language,
 }
 
 static INDICES_SORTABLE_ENTRIES *
-setup_sortable_index_entries (INDEX_COLLATOR *collator,
+setup_sortable_index_entries (const INDEX_COLLATOR *collator,
                          const INDICES_SORT_STRINGS *indices_sort_strings)
 {
   size_t i;
@@ -671,7 +671,7 @@ setup_sortable_index_entries (INDEX_COLLATOR *collator,
                     = &sortable_entry->sortable_subentries[k];
                   INDEX_SUBENTRY_SORT_STRING *subenty_sort_string
                     = &index_entry_sort_string->sort_string_subentries[k];
-                  /* TODO or refer to subenty_sort_string structure? */
+
                   sortable_subentry->sort_string
                     = strdup (subenty_sort_string->sort_string);
                   sortable_subentry->alpha = subenty_sort_string->alpha;