[no subject]

[Patrice Dumas]

branch: master
commit a8a99593554bde43e1c7f6716d8c81bf22fbcce8
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Tue Jan 9 13:48:28 2024 +0100

    Commit .h file too
    
    * tp/Texinfo/XS/convert/build_html_perl_state.c
    (build_html_formatting_state): do not return anything.  This probably
    fixes a wrong refcount too.
---
 ChangeLog                                     | 6 ++++++
 tp/Texinfo/XS/convert/build_html_perl_state.c | 7 ++-----
 tp/Texinfo/XS/convert/build_html_perl_state.h | 2 +-
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8395b0f362..3559c91296 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-01-09  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/convert/build_html_perl_state.c
+       (build_html_formatting_state): do not return anything.  This probably
+       fixes a wrong refcount too.
+
 2024-01-08  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/Convert/Converter.pm (converter),
diff --git a/tp/Texinfo/XS/convert/build_html_perl_state.c 
b/tp/Texinfo/XS/convert/build_html_perl_state.c
index 4b1462c42e..d5ca052589 100644
--- a/tp/Texinfo/XS/convert/build_html_perl_state.c
+++ b/tp/Texinfo/XS/convert/build_html_perl_state.c
@@ -363,8 +363,7 @@ build_html_translated_names (HV *hv, CONVERTER *converter)
 
 }
 
-/* there is no need to return anything. */
-SV *
+void
 build_html_formatting_state (CONVERTER *converter, unsigned long flags)
 {
   HV *hv;
@@ -377,7 +376,7 @@ build_html_formatting_state (CONVERTER *converter, unsigned 
long flags)
   dTHX;
 
   if (!converter->hv)
-    return newSV (0);
+    return;
 
   hv = converter->hv;
 
@@ -462,8 +461,6 @@ build_html_formatting_state (CONVERTER *converter, unsigned 
long flags)
 
   if (flags & HMSF_translations)
     build_html_translated_names (hv, converter);
-
-  return newRV_noinc ((SV *) hv);
 }
 
 SV *
diff --git a/tp/Texinfo/XS/convert/build_html_perl_state.h 
b/tp/Texinfo/XS/convert/build_html_perl_state.h
index 1a3dbba239..c17b35f9c4 100644
--- a/tp/Texinfo/XS/convert/build_html_perl_state.h
+++ b/tp/Texinfo/XS/convert/build_html_perl_state.h
@@ -22,7 +22,7 @@ void pass_html_global_units_directions (SV *converter_sv,
 void pass_html_elements_in_file_count (SV *converter_sv,
                    FILE_NAME_PATH_COUNTER_LIST *output_unit_files);
 
-SV *build_html_formatting_state (CONVERTER *converter, unsigned long flags);
+void build_html_formatting_state (CONVERTER *converter, unsigned long flags);
 
 SV *build_html_command_formatted_args
            (const HTML_ARGS_FORMATTED *args_formatted);