[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
branch master updated: * tp/Texinfo/Convert/ParagraphNonXS.pm: remove a
From: |
Patrice Dumas |
Subject: |
branch master updated: * tp/Texinfo/Convert/ParagraphNonXS.pm: remove a FIXME comment fixed. * tp/TODO: update. |
Date: |
Sun, 26 Nov 2023 13:02:13 -0500 |
This is an automated email from the git hooks/post-receive script.
pertusus pushed a commit to branch master
in repository texinfo.
The following commit(s) were added to refs/heads/master by this push:
new 73695c4cde * tp/Texinfo/Convert/ParagraphNonXS.pm: remove a FIXME
comment fixed. * tp/TODO: update.
73695c4cde is described below
commit 73695c4cdeb33005259b2d0f9eb64f81a3d85c30
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Sun Nov 26 19:02:05 2023 +0100
* tp/Texinfo/Convert/ParagraphNonXS.pm: remove a FIXME comment fixed.
* tp/TODO: update.
---
ChangeLog | 5 ++++
tp/TODO | 56 ++++++------------------------------
tp/Texinfo/Convert/ParagraphNonXS.pm | 2 --
3 files changed, 14 insertions(+), 49 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ec9a66c3e6..e17efa2927 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2023-11-26 Patrice Dumas <pertusus@free.fr>
+
+ * tp/Texinfo/Convert/ParagraphNonXS.pm: remove a FIXME comment fixed.
+ * tp/TODO: update.
+
2023-11-26 Patrice Dumas <pertusus@free.fr>
* tp/Makefile.am b/tp/Makefile.am (dist_init_DATA): add
diff --git a/tp/TODO b/tp/TODO
index 99bec0b503..74a4c4bc07 100644
--- a/tp/TODO
+++ b/tp/TODO
@@ -10,23 +10,13 @@ This is the todo list for texi2any
Before next release
===================
-check $(native_tools) variable in Makefile.am does not seems to be
-set and seems useless.
-
-For unicode sorting in C for index sorting, strcoll_l or even better strxfrm_l
-could be used, it sorts according to a locale specified in argument. However,
-it does not seems to be that portable, there is no associated gnulib
-module, and the _l variants seem to be in glibc but are are not in the glibc
-documentation. According to Eli, if the locale's codeset is UTF-8, glibc
-uses the full Unicode CLDR, which is what we want.
-
Document that Texinfo::Document::rebuild_document or
Texinfo::Document::rebuild_tree should be called after tree modifications
if the parser is XS but converters are perl.
Add a comment/TODO somewhere that explains that the need to maintain
-perl and C document contexts exactly in sync is probably a bug somewhere.
-Indeed, the change in perl document context should not need to be
+perl and C HTML document contexts exactly in sync is probably a bug somewhere.
+Indeed, the change in perl HTML document context should not need to be
transmitted to C (through overriding of _new_document_context
and _pop_document_context) as perl does not call any XS/C formatting
function -- with the exception of translate_names -- and therefore the
@@ -81,6 +71,13 @@ For converter writers,
Delayed bugs
============
+For unicode sorting in C for index sorting, strcoll_l or even better strxfrm_l
+could be used, it sorts according to a locale specified in argument. However,
+it does not seems to be that portable, there is no associated gnulib
+module, and the _l variants seem to be in glibc but are are not in the glibc
+documentation. According to Eli, if the locale's codeset is UTF-8, glibc
+uses the full Unicode CLDR, which is what we want.
+
hyphenation: should only appear in toplevel.
@@ -185,41 +182,6 @@ translate a perl tree in input, but access directly the C
tree that
was setup by the XS parser.
-It would probably be good and maybe ease C converters to have a
-Texinfo::Document package which encapsulates the information associated
-to a document, the tree, and all the other information given by
-the parser, indices_information, floats_information,
-internal_references_information, global_commands_information,
-global_information and labels_information as they are a property of a Texinfo
-Document, in addition to being, in general, states of a parser. The
-information set by some calls to Structuring would also probably fit there
-naturally. A member of the package/class would be initialized after the
-parsing, but not necessarily for all the function, maybe only parse_texi_text
-and parse_texi_file.
-
-For transliteration, use in iconv ascii//TRANSLIT?
-
-For nodenormalization
-Constant: uc_property_t UC_PROPERTY_DIACRITIC
-Function: bool uc_is_property (ucs4_t uc, uc_property_t property)
-
-Note that there is a function, not currently used, that could be reused in
api.c:
-find_locales_dir
-
-
-For Paragraph, improvements and synchronizations of
-the two implementations. It would be nice to change the XS code
-to operate on multiple spans of characters at once when relevant,
-we'd have an extra step of keeping track of how long each span of
-text is, and then processing that span of text together (in the loop
-in xspara_add_text). It could potentiall have performance benefits
-(e.g. reducing the number of function calls) and be easier to debug,
-with fewer steps in the processing to trace. The XS code is easier
-to read for the ens of sentence handling part, so for that part, it
-could be relevant to use the XS code as reference and change the perl
-Paragraph.
-
-
From Gavin on the preamble_before_beginning implementation:
Another way might be to add special input code to trim off and return
a file prelude. This would moves the handling of this from the "parser" code
diff --git a/tp/Texinfo/Convert/ParagraphNonXS.pm
b/tp/Texinfo/Convert/ParagraphNonXS.pm
index dbb92db179..89a3118ea8 100644
--- a/tp/Texinfo/Convert/ParagraphNonXS.pm
+++ b/tp/Texinfo/Convert/ParagraphNonXS.pm
@@ -186,8 +186,6 @@ my $end_sentence_characters = quotemeta('.?!');
my $after_punctuation_characters = quotemeta('"\')]');
# Add $WORD to paragraph, returning the text to be added to the paragraph.
-# FIXME: remove handling of \x08 control characters from add_next, doing it
-# in add_text instead (as is done in the corresponding XS code).
sub add_next($;$$)
{
my $paragraph = shift;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- branch master updated: * tp/Texinfo/Convert/ParagraphNonXS.pm: remove a FIXME comment fixed. * tp/TODO: update.,
Patrice Dumas <=