branch master updated: * tp/texi2any.supp: Add suppression specification for leaks associated to switch_to_global_locale and setenv showing up with t/19def.t all_commands_delimiters.

[Patrice Dumas]

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 2ef44d0e09 * tp/texi2any.supp: Add suppression specification for leaks 
associated to switch_to_global_locale and setenv showing up with t/19def.t 
all_commands_delimiters.
2ef44d0e09 is described below

commit 2ef44d0e096e0d6f6ac801142404e6642bcf5868
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Sun Nov 19 18:49:13 2023 +0100

    * tp/texi2any.supp: Add suppression specification for leaks associated
    to switch_to_global_locale and setenv showing up with t/19def.t
    all_commands_delimiters.
---
 ChangeLog        |  6 ++++++
 tp/TODO          | 10 ++++++----
 tp/texi2any.supp | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++---
 3 files changed, 62 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f7c44eaa12..50d19c0765 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2023-11-19  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/texi2any.supp: Add suppression specification for leaks associated
+       to switch_to_global_locale and setenv showing up with t/19def.t
+       all_commands_delimiters.
+
 2023-11-19  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/XS/main/get_perl_info.c (set_output_converter_sv):
diff --git a/tp/TODO b/tp/TODO
index a2b1049e17..c81f49fb71 100644
--- a/tp/TODO
+++ b/tp/TODO
@@ -720,16 +720,18 @@ In tp/tests/, generate Texinfo file for Texinfo TeX 
coverage
 From doc/
 texi2pdf -I ../tp/tests/layout/ ../tp/tests/formatting_valid.texi
 
+To generate valgrind .supp rules: --gen-suppressions=all 
--log-file=gen_supp_rules.log
 mkdir -p val_res
 PERL_DESTRUCT_LEVEL=2
 export PERL_DESTRUCT_LEVEL
-for file in t/*.t ; do bfile=`basename $file .t`; echo $bfile; valgrind -q 
perl -w $file > val_res/$bfile.out 2>&1 ; done
+for file in t/*.t ; do bfile=`basename $file .t`; echo $bfile; valgrind 
--suppressions=./texi2any.supp -q perl -w $file > val_res/$bfile.out 2>&1 ; done
 
 With memory leaks
-for file in t/*.t ; do bfile=`basename $file .t`; echo $bfile; valgrind -q 
--leak-check=full perl -w $file > val_res/$bfile.out 2>&1 ; done
+for file in t/*.t ; do bfile=`basename $file .t`; echo $bfile; valgrind 
--suppressions=./texi2any.supp -q --leak-check=full perl -w $file > 
val_res/$bfile.out 2>&1 ; done
 
-For tests in tp/tests, a way to have valgrind -q prependend is to add, in 
tp/defs:
-prepended_command='valgrind -q'
+For tests in tp/tests, a way to have valgrind call prependend is to add,
+in tp/defs:
+prepended_command='valgrind --leak-check=full -q 
--suppressions=../texi2any.supp'
 
 rm -rf t/check_debug_differences/
 mkdir t/check_debug_differences/
diff --git a/tp/texi2any.supp b/tp/texi2any.supp
index a82c09dfac..3d62c46b4b 100644
--- a/tp/texi2any.supp
+++ b/tp/texi2any.supp
@@ -3,7 +3,7 @@
 # Leak occurs when switch_to_global_locale is called in main/translations.c.
 # Occurs in Perl 5.36.
 {
-   translations/switch_to_global_locale
+   Leak/translations/switch_to_global_locale/1
    Memcheck:Leak
    match-leak-kinds: definite
    fun:malloc
@@ -20,12 +20,59 @@
    fun:Perl_newATTRSUB_x
 }
 
+# Leak, most likely call of switch_to_global_locale is called in 
main/translations.c.
+# Occurs in Perl 5.36.
+{
+   Leak/translations/switch_to_global_locale/
+   Memcheck:Leak
+   match-leak-kinds: definite
+   fun:malloc
+   fun:newlocale
+   fun:S_emulate_setlocale
+   fun:Perl_sync_locale
+   fun:translate_string
+   ...
+}
+
+# Leaks in translations setenv
+# Occurs in Perl 5.36.
+{
+   Leak/translations/setenv/1
+   Memcheck:Leak
+   match-leak-kinds: definite
+   fun:malloc
+   fun:Perl_safesysmalloc
+   fun:S_env_alloc
+   fun:Perl_my_setenv
+   fun:Perl_magic_setenv
+   fun:Perl_mg_set
+   fun:Perl_pp_sassign
+   fun:Perl_runops_standard
+   fun:Perl_call_sv
+   fun:Perl_call_list
+   fun:S_process_special_blocks
+   fun:Perl_newATTRSUB_x
+   fun:Perl_yyparse
+   fun:S_doeval_compile
+}
+{
+   Leak/translations/setenv/2
+   Memcheck:Leak
+   match-leak-kinds: definite
+   fun:malloc
+   fun:Perl_safesysmalloc
+   fun:S_env_alloc
+   fun:Perl_my_setenv
+   fun:perl_parse
+   fun:main
+}
+
 # Errors output due to use of setenv in XS module.
 # Occurs in Perl 5.36, fixed in Perl 5.38.
 # See <https://github.com/Perl/perl5/issues/19399> and
 # <https://rt.cpan.org/Public/Bug/Display.html?id=140138>.
 {
-   fixed-in-perl/translations/setenv/1
+   fixed-in-perl/Free/translations/setenv/1
    Memcheck:Free
    fun:free
    ...
@@ -39,7 +86,7 @@
    fun:main
 }
 {
-   fixed-in-perl/translations/setenv/2
+   fixed-in-perl/Free/translations/setenv/2
    Memcheck:Free
    fun:free
    ...