[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
branch master updated: * tp/Texinfo/Convert/ParagraphNonXS.pm (add_next,
From: |
Gavin D. Smith |
Subject: |
branch master updated: * tp/Texinfo/Convert/ParagraphNonXS.pm (add_next, add_text): Add FIXME comment saying to make the code more like the XS code in handling of \x08 control characters. |
Date: |
Sat, 21 Oct 2023 07:59:23 -0400 |
This is an automated email from the git hooks/post-receive script.
gavin pushed a commit to branch master
in repository texinfo.
The following commit(s) were added to refs/heads/master by this push:
new a007aa9450 * tp/Texinfo/Convert/ParagraphNonXS.pm (add_next,
add_text): Add FIXME comment saying to make the code more like the XS code in
handling of \x08 control characters.
a007aa9450 is described below
commit a007aa9450514ff0ef673822ada07c48caefa93d
Author: Gavin Smith <gavinsmith0123@gmail.com>
AuthorDate: Sat Oct 21 12:59:16 2023 +0100
* tp/Texinfo/Convert/ParagraphNonXS.pm (add_next, add_text):
Add FIXME comment saying to make the code more like the XS code
in handling of \x08 control characters.
---
ChangeLog | 6 ++++++
tp/Texinfo/Convert/ParagraphNonXS.pm | 8 +++++---
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8c0c536749..be247ef46b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2023-10-21 Gavin Smith <gavinsmith0123@gmail.com>
+
+ * tp/Texinfo/Convert/ParagraphNonXS.pm (add_next, add_text):
+ Add FIXME comment saying to make the code more like the XS code
+ in handling of \x08 control characters.
+
2023-10-21 Gavin Smith <gavinsmith0123@gmail.com>
* tp/Texinfo/Convert/Plaintext.pm (_convert): Move a block
diff --git a/tp/Texinfo/Convert/ParagraphNonXS.pm
b/tp/Texinfo/Convert/ParagraphNonXS.pm
index 164661e9b3..d107fe1efc 100644
--- a/tp/Texinfo/Convert/ParagraphNonXS.pm
+++ b/tp/Texinfo/Convert/ParagraphNonXS.pm
@@ -186,9 +186,8 @@ my $end_sentence_characters = quotemeta('.?!');
my $after_punctuation_characters = quotemeta('"\')]');
# Add $WORD to paragraph, returning the text to be added to the paragraph.
-# Any end of sentence punctuation in $WORD that should be allowed to end a
-# sentence but which would otherwise be preceded by an upper-case letter should
-# instead by preceded by a backspace character.
+# FIXME: remove handling of \x08 control characters from add_next, doing it
+# in add_text instead (as is done in the corresponding XS code).
sub add_next($;$$)
{
my $paragraph = shift;
@@ -301,6 +300,9 @@ sub set_space_protection($$;$$$$)
# of $PARAGRAPH. Any end of sentence punctuation in $TEXT that should be
# allowed to end a sentence but which would otherwise be preceded by an
# upper-case letter should instead by preceded by a backspace character.
+#
+# FIXME: remove handling of \x08 control characters from add_next, doing it
+# in add_text instead (as is done in the corresponding XS code).
sub add_text($$)
{
my $paragraph = shift;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- branch master updated: * tp/Texinfo/Convert/ParagraphNonXS.pm (add_next, add_text): Add FIXME comment saying to make the code more like the XS code in handling of \x08 control characters.,
Gavin D. Smith <=