branch master updated: * README-hacking: remove recommendation to check with -Wdeclaration-after-statement, as it may not be a relevant warning any more. From Bruno.

[Gavin D. Smith]

This is an automated email from the git hooks/post-receive script.

gavin pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 2ef3ac36ac * README-hacking: remove recommendation to check with 
-Wdeclaration-after-statement, as it may not be a relevant warning any more.  
From Bruno.
2ef3ac36ac is described below

commit 2ef3ac36ac54ad6898bb639993e120314986045d
Author: Gavin Smith <gavinsmith0123@gmail.com>
AuthorDate: Fri Aug 18 15:04:18 2023 +0100

    * README-hacking: remove recommendation to check with
    -Wdeclaration-after-statement, as it may not be a relevant
    warning any more.  From Bruno.
---
 ChangeLog      | 6 ++++++
 README-hacking | 7 +------
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c7be40186c..cb4061dbff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2023-08-18  Gavin Smith <gavinsmith0123@gmail.com>
+
+       * README-hacking: remove recommendation to check with
+       -Wdeclaration-after-statement, as it may not be a relevant
+       warning any more.  From Bruno.
+
 2023-08-18  Gavin Smith <gavinsmith0123@gmail.com>
 
        * install-info/install-info.c (readfile): null-terminate file
diff --git a/README-hacking b/README-hacking
index b9a62d1243..1dae0b2722 100644
--- a/README-hacking
+++ b/README-hacking
@@ -243,15 +243,10 @@ Manual testing:
 
 check for C compiler warnings by configuring with
 
-our_CFLAGS='-Wall -Wdeclaration-after-statement -Wno-parentheses 
-Wno-missing-braces'
+our_CFLAGS='-Wall -Wno-parentheses -Wno-missing-braces'
 ./configure "CFLAGS=$our_CFLAGS" "PERL_EXT_CFLAGS=$our_CFLAGS"
 unset our_CFLAGS
 
--Wdeclaration-after-statement is useful because a) intermixing
-declarations with statements is an easy thing to do accidentally,
-b) gcc doesn't warn about it by default, and c) other compilers that
-don't support it are still widespread.
-
 Not all compiler warnings have to be fixed, though.