[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[no subject]
From: |
Gavin D. Smith |
Date: |
Mon, 10 Apr 2023 12:38:33 -0400 (EDT) |
branch: master
commit c65b8b5e5556e427bbb66d4a5a7dab08351f0a8d
Author: Gavin Smith <gavinsmith0123@gmail.com>
AuthorDate: Mon Apr 10 17:38:23 2023 +0100
* tp/Texinfo/XS/parsetexi/input.c (encode_with_iconv):
Remove spurious comment.
---
ChangeLog | 5 +++++
tp/Texinfo/XS/parsetexi/input.c | 4 +---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 890e20c0fc..6729ff809e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2023-04-10 Gavin Smith <gavinsmith0123@gmail.com>
+
+ * tp/Texinfo/XS/parsetexi/input.c (encode_with_iconv):
+ Remove spurious comment.
+
2023-04-10 Gavin Smith <gavinsmith0123@gmail.com>
* README-hacking: add note of LD_BIND_NOW variable for callgrind
diff --git a/tp/Texinfo/XS/parsetexi/input.c b/tp/Texinfo/XS/parsetexi/input.c
index b6b90e5f10..afd4ed77b6 100644
--- a/tp/Texinfo/XS/parsetexi/input.c
+++ b/tp/Texinfo/XS/parsetexi/input.c
@@ -177,7 +177,7 @@ encode_with_iconv (iconv_t our_iconv, char *s)
ICONV_CONST char *inptr; size_t bytes_left;
size_t iconv_ret;
- t.end = 0;
+ t.end = 0; /* reset internal TEXT buffer */
inptr = s;
bytes_left = strlen (s);
text_alloc (&t, 10);
@@ -215,8 +215,6 @@ encode_with_iconv (iconv_t our_iconv, char *s)
}
t.text[t.end] = '\0';
- /* FIXME freeing t.text leads to invalid memory access in the loop
- above, both in the case E2BIG and in text_buffer_iconv */
return strdup (t.text);
}