[5523] some comments added and small fix

[Gavin D. Smith]

Revision: 5523
          http://svn.sv.gnu.org/viewvc/?view=rev&root=texinfo&revision=5523
Author:   gavin
Date:     2014-05-07 11:39:16 +0000 (Wed, 07 May 2014)
Log Message:
-----------
some comments added and small fix

Modified Paths:
--------------
    trunk/ChangeLog
    trunk/info/info.c
    trunk/info/pseudotty.c
    trunk/info/t/Init-intera.inc

Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog     2014-05-07 00:03:06 UTC (rev 5522)
+++ trunk/ChangeLog     2014-05-07 11:39:16 UTC (rev 5523)
@@ -1,5 +1,16 @@
-2014-05-04  Gavin Smith  <address@hidden>
+2014-05-07  Gavin Smith  <address@hidden>
 
+       * info/info.c (add_initial_nodes): Don't free return value of
+       info_indices_of_file_buffer.
+
+       * info/pseudotty.c: #define _GNU_SOURCE instead.  Note
+       added on the portability of various functions.
+
+       * info/t/Init-intera.inc: Note added on problem with crashes
+       during tests.
+
+2014-05-06  Gavin Smith  <address@hidden>
+
        * info/session.c (begin_multiple_window_info_session): Take
        array of REFERENCE * arguments.  Caller in info.c:main updated.
        (info_select_reference): Go to line number given by reference.

Modified: trunk/info/info.c
===================================================================
--- trunk/info/info.c   2014-05-07 00:03:06 UTC (rev 5522)
+++ trunk/info/info.c   2014-05-07 11:39:16 UTC (rev 5523)
@@ -356,7 +356,6 @@
               break;
             }
         }
-      free (index);
     }
 
   /* If still no nodes and there are arguments remaining, follow menus

Modified: trunk/info/pseudotty.c
===================================================================
--- trunk/info/pseudotty.c      2014-05-07 00:03:06 UTC (rev 5522)
+++ trunk/info/pseudotty.c      2014-05-07 11:39:16 UTC (rev 5523)
@@ -17,7 +17,8 @@
    standard output.  Read and ignore any data sent to terminal.  This
    is so we can run tests interactively without messing up the screen. */
 
-#define _XOPEN_SOURCE
+#define _GNU_SOURCE
+
 #include <stdlib.h>
 #include <stdio.h>
 #include <fcntl.h>
@@ -29,6 +30,8 @@
 
 main ()
 {
+  /* Note getpt is a GNU extension.  grantpt, ptsname, unlockpt are
+     specified in POSIX.1-2001. */
   master = getpt();
   if (master == -1)
     exit (1);

Modified: trunk/info/t/Init-intera.inc
===================================================================
--- trunk/info/t/Init-intera.inc        2014-05-07 00:03:06 UTC (rev 5522)
+++ trunk/info/t/Init-intera.inc        2014-05-07 11:39:16 UTC (rev 5523)
@@ -5,6 +5,13 @@
 # We could perhaps use AM_TESTS_FD_REDIRECT in Makefile.am instead,
 # although this would stop us from running test scripts from the command-line.
 
+# FIXME: If ginfo segfaults in the middle of a test when running interactively,
+# it will mess up the terminal settings, even though both stdout and stderr
+# have been redirected.  A newline character sent to the terminal does not
+# do a carriage return, and characters typed at the keyboard are not echoed.
+# Find out why this is happening.  The program must still have some
+# reference to the terminal.
+
 GINFO_PTY_FILE=$0.pty
 rm -f $GINFO_PTY_FILE
 ./pseudotty >$GINFO_PTY_FILE &