[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[5353] * tp/Texinfo/Convert/Info.pm (_node): warn if node name c
From: |
Patrice Dumas |
Subject: |
[5353] * tp/Texinfo/Convert/Info.pm (_node): warn if node name contains |
Date: |
Sun, 01 Sep 2013 19:14:58 +0000 |
Revision: 5353
http://svn.sv.gnu.org/viewvc/?view=rev&root=texinfo&revision=5353
Author: pertusus
Date: 2013-09-01 19:14:58 +0000 (Sun, 01 Sep 2013)
Log Message:
-----------
* tp/Texinfo/Convert/Info.pm (_node): warn if node name contains
a comma.
Modified Paths:
--------------
trunk/ChangeLog
trunk/tp/Texinfo/Convert/Info.pm
trunk/tp/t/results/converters_tests/at_commands_in_refs.pl
trunk/tp/t/results/converters_tests/at_commands_in_refs_latin1.pl
trunk/tp/t/results/converters_tests/at_commands_in_refs_utf8.pl
trunk/tp/t/results/converters_tests/some_at_commands_in_ref_nodes.pl
trunk/tp/tests/coverage/res_parser_info/formatting/formatting.2
trunk/tp/tests/coverage/res_parser_info/formatting_cr/formatting-cr.2
trunk/tp/tests/coverage/res_parser_info/formatting_fr/formatting.2
trunk/tp/tests/coverage/res_parser_info/formatting_utf8_enable_encoding/formatting_utf8.2
Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog 2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/ChangeLog 2013-09-01 19:14:58 UTC (rev 5353)
@@ -1,3 +1,8 @@
+2013-09-01 Patrice Dumas <address@hidden>
+
+ * tp/Texinfo/Convert/Info.pm (_node): warn if node name contains
+ a comma.
+
2013-08-31 Patrice Dumas <address@hidden>
* tp/Texinfo/Convert/Plaintext.pm: warn when cross-reference
Modified: trunk/tp/Texinfo/Convert/Info.pm
===================================================================
--- trunk/tp/Texinfo/Convert/Info.pm 2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/tp/Texinfo/Convert/Info.pm 2013-09-01 19:14:58 UTC (rev 5353)
@@ -401,6 +401,11 @@
$result .= $node_begin;
$self->_add_text_count($node_begin);
my ($node_text, $byte_count) = $self->_node_line($node);
+ if ($node_text =~ /,/) {
+ $self->line_warn(sprintf($self->__(
+ "address@hidden name should not contain `,': %s"), $node_text),
+ $node->{'line_nr'});
+ }
$self->{'count_context'}->[-1]->{'bytes'} += $byte_count;
$result .= $node_text;
foreach my $direction(@directions) {
Modified: trunk/tp/t/results/converters_tests/at_commands_in_refs.pl
===================================================================
--- trunk/tp/t/results/converters_tests/at_commands_in_refs.pl 2013-08-31
14:08:30 UTC (rev 5352)
+++ trunk/tp/t/results/converters_tests/at_commands_in_refs.pl 2013-09-01
19:14:58 UTC (rev 5353)
@@ -23286,6 +23286,42 @@
},
{
'file_name' => '',
+ 'error_line' => ':42: warning: @node name should not contain `,\': LaTeX
TeX * , (C) ... ...
+',
+ 'text' => '@node name should not contain `,\': LaTeX TeX * , (C) ... ...',
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 42
+ },
+ {
+ 'file_name' => '',
+ 'error_line' => ':60: warning: @node name should not contain `,\': a" e~
i^ a^ a` e\' c, e= e* e\'\' e;
+',
+ 'text' => '@node name should not contain `,\': a" e~ i^ a^ a` e\' c, e= e*
e\'\' e;',
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 60
+ },
+ {
+ 'file_name' => '',
+ 'error_line' => ':66: warning: @node name should not contain `,\': i E=`
C\',
+',
+ 'text' => '@node name should not contain `,\': i E=` C\',',
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 66
+ },
+ {
+ 'file_name' => '',
+ 'error_line' => ':69: warning: @node name should not contain `,\': `` \'\'
` \' ,, ,
+',
+ 'text' => '@node name should not contain `,\': `` \'\' ` \' ,, ,',
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 69
+ },
+ {
+ 'file_name' => '',
'error_line' => ':89: warning: could not find @image file `f--ile1.txt\'
nor alternate text
',
'text' => 'could not find @image file `f--ile1.txt\' nor alternate text',
Modified: trunk/tp/t/results/converters_tests/at_commands_in_refs_latin1.pl
===================================================================
--- trunk/tp/t/results/converters_tests/at_commands_in_refs_latin1.pl
2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/tp/t/results/converters_tests/at_commands_in_refs_latin1.pl
2013-09-01 19:14:58 UTC (rev 5353)
@@ -22286,6 +22286,33 @@
},
{
'file_name' => '',
+ 'error_line' => ":45: warning: address@hidden name should not contain `,':
LaTeX TeX * , \x{a9} ... ...
+",
+ 'text' => "address@hidden name should not contain `,': LaTeX TeX * ,
\x{a9} ... ...",
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 45
+ },
+ {
+ 'file_name' => '',
+ 'error_line' => ':69: warning: @node name should not contain `,\': i E=`
C\',
+',
+ 'text' => '@node name should not contain `,\': i E=` C\',',
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 69
+ },
+ {
+ 'file_name' => '',
+ 'error_line' => ':72: warning: @node name should not contain `,\': `` \'\'
` \' ,, ,
+',
+ 'text' => '@node name should not contain `,\': `` \'\' ` \' ,, ,',
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 72
+ },
+ {
+ 'file_name' => '',
'error_line' => ':92: warning: could not find @image file `f--ile1.txt\'
nor alternate text
',
'text' => 'could not find @image file `f--ile1.txt\' nor alternate text',
Modified: trunk/tp/t/results/converters_tests/at_commands_in_refs_utf8.pl
===================================================================
--- trunk/tp/t/results/converters_tests/at_commands_in_refs_utf8.pl
2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/tp/t/results/converters_tests/at_commands_in_refs_utf8.pl
2013-09-01 19:14:58 UTC (rev 5353)
@@ -22286,6 +22286,15 @@
},
{
'file_name' => '',
+ 'error_line' => ":45: warning: address@hidden name should not contain `,':
LaTeX TeX \x{2022} , \x{a9} \x{2026} ...
+",
+ 'text' => "address@hidden name should not contain `,': LaTeX TeX \x{2022}
, \x{a9} \x{2026} ...",
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 45
+ },
+ {
+ 'file_name' => '',
'error_line' => ':92: warning: could not find @image file `f--ile1.txt\'
nor alternate text
',
'text' => 'could not find @image file `f--ile1.txt\' nor alternate text',
Modified: trunk/tp/t/results/converters_tests/some_at_commands_in_ref_nodes.pl
===================================================================
--- trunk/tp/t/results/converters_tests/some_at_commands_in_ref_nodes.pl
2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/tp/t/results/converters_tests/some_at_commands_in_ref_nodes.pl
2013-09-01 19:14:58 UTC (rev 5353)
@@ -1830,4 +1830,17 @@
End Tag Table
';
+$result_converted_errors{'info'}->{'some_at_commands_in_ref_nodes'} = [
+ {
+ 'file_name' => '',
+ 'error_line' => ':9: warning: @node name should not contain `,\': A SC N~
AA TeX node i" i" E=` /l C\', !
+',
+ 'text' => '@node name should not contain `,\': A SC N~ AA TeX node i" i"
E=` /l C\', !',
+ 'type' => 'warning',
+ 'macro' => '',
+ 'line_nr' => 9
+ }
+];
+
+
1;
Modified: trunk/tp/tests/coverage/res_parser_info/formatting/formatting.2
===================================================================
--- trunk/tp/tests/coverage/res_parser_info/formatting/formatting.2
2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/tp/tests/coverage/res_parser_info/formatting/formatting.2
2013-09-01 19:14:58 UTC (rev 5353)
@@ -44,3 +44,4 @@
formatting.texi:49: command @minus not accepting argument in brace should not
be on @ftable line (possibly involving @mymacro)
formatting.texi:49: warning: @ref node name should not contain `,' (possibly
involving @mymacro)
formatting.texi:49: warning: @inforef node name should not contain `,'
(possibly involving @mymacro)
+formatting.texi:99: warning: @node name should not contain `,': s--ect,ion
Modified: trunk/tp/tests/coverage/res_parser_info/formatting_cr/formatting-cr.2
===================================================================
--- trunk/tp/tests/coverage/res_parser_info/formatting_cr/formatting-cr.2
2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/tp/tests/coverage/res_parser_info/formatting_cr/formatting-cr.2
2013-09-01 19:14:58 UTC (rev 5353)
@@ -68,3 +68,4 @@
formatting-cr.texi:49: command @minus not accepting argument in brace should
not be on @ftable line (possibly involving @mymacro)
formatting-cr.texi:49: warning: @ref node name should not contain `,'
(possibly involving @mymacro)
formatting-cr.texi:49: warning: @inforef node name should not contain `,'
(possibly involving @mymacro)
+formatting-cr.texi:99: warning: @node name should not contain `,': s--ect,ion
Modified: trunk/tp/tests/coverage/res_parser_info/formatting_fr/formatting.2
===================================================================
--- trunk/tp/tests/coverage/res_parser_info/formatting_fr/formatting.2
2013-08-31 14:08:30 UTC (rev 5352)
+++ trunk/tp/tests/coverage/res_parser_info/formatting_fr/formatting.2
2013-09-01 19:14:58 UTC (rev 5353)
@@ -44,3 +44,4 @@
formatting.texi:49: command @minus not accepting argument in brace should not
be on @ftable line (possibly involving @mymacro)
formatting.texi:49: warning: @ref node name should not contain `,' (possibly
involving @mymacro)
formatting.texi:49: warning: @inforef node name should not contain `,'
(possibly involving @mymacro)
+formatting.texi:99: warning: @node name should not contain `,': s--ect,ion
Modified:
trunk/tp/tests/coverage/res_parser_info/formatting_utf8_enable_encoding/formatting_utf8.2
===================================================================
---
trunk/tp/tests/coverage/res_parser_info/formatting_utf8_enable_encoding/formatting_utf8.2
2013-08-31 14:08:30 UTC (rev 5352)
+++
trunk/tp/tests/coverage/res_parser_info/formatting_utf8_enable_encoding/formatting_utf8.2
2013-09-01 19:14:58 UTC (rev 5353)
@@ -45,3 +45,4 @@
formatting_utf8.texi:51: command @minus not accepting argument in brace should
not be on @ftable line (possibly involving @mymacro)
formatting_utf8.texi:51: warning: @ref node name should not contain `,'
(possibly involving @mymacro)
formatting_utf8.texi:51: warning: @inforef node name should not contain `,'
(possibly involving @mymacro)
+formatting_utf8.texi:101: warning: @node name should not contain `,':
s--ect,ion
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [5353] * tp/Texinfo/Convert/Info.pm (_node): warn if node name contains,
Patrice Dumas <=