Re: [Taler] GNUnet and taler v0.9.4

[Christian Grothoff]

Hi Slack Coder,

GNUNET_PQ_ is correct, an _older_ version of GNUnet (pre v0.21) had a 
typo an incorrectly used the "GNUNET_PG_" prefix. So I strongly suspect 
you're not actually compiling against GNUnet v0.21; maybe you have two 
versions of GNUnet installed on your system and are accidentally linking 
against an older version?

My 2 cents

Christian

On 3/10/24 14:50, Slack Coder wrote:
> Hi,
>
> What is taler's GNUnet dependency for version v0.9.4?  Compiling 
> taler-exchange v0.9.4a against v0.21.0 throws compile time errors:
>
> ```
>
> pg_reserves_in_insert.c:54:10: error: call to undeclared function 
> 'GNUNET_PQ_get_event_notify_channel'; ISO C99 and later do not support 
> implicit function declarations [-Wimplicit-function-declaration]
>     54 |   return GNUNET_PQ_get_event_notify_channel (&rep.header);
>        |          ^
> pg_reserves_in_insert.c:54:10: note: did you mean 
> 'GNUNET_PG_get_event_notify_channel'?
> /usr/local/include/gnunet/gnunet_pq_lib.h:1624:1: note: 
> 'GNUNET_PG_get_event_notify_channel' declared here
>   1624 | GNUNET_PG_get_event_notify_channel (const struct 
> GNUNET_DB_EventHeaderP *es);
>        | ^
> pg_reserves_in_insert.c:54:10: error: incompatible integer to pointer 
> conversion returning 'int' from a function with result type 'char *' 
> [-Wint-conversion]
>     54 |   return GNUNET_PQ_get_event_notify_channel (&rep.header);
>
> ```
>
> Replacing 'GNUNET_PQ_get_event_notify_channel' with 
> 'GNUNET_PG_get_event_notify_channel' fixes the error, but is it correct?
>
> Thanks,
>
> SC
>
> diff --git a/src/exchangedb/pg_insert_aml_decision.c 
> b/src/exchangedb/pg_insert_aml_decision.c
> index 39419be59..a3653824c 100644
> --- a/src/exchangedb/pg_insert_aml_decision.c
> +++ b/src/exchangedb/pg_insert_aml_decision.c
> @@ -49,7 +49,7 @@ TEH_PG_insert_aml_decision (
>       .header.type = htons (TALER_DBEVENT_EXCHANGE_KYC_COMPLETED),
>       .h_payto = *h_payto
>     };
> -  char *notify_s = GNUNET_PQ_get_event_notify_channel (&rep.header);
> +  char *notify_s = GNUNET_PG_get_event_notify_channel (&rep.header);
>     char *kyc_s = (NULL != kyc_requirements)
>       ? json_dumps (kyc_requirements, JSON_COMPACT)
>       : NULL;
> diff --git a/src/exchangedb/pg_insert_kyc_attributes.c 
> b/src/exchangedb/pg_insert_kyc_attributes.c
> index 3c94abb85..8b3cf84c6 100644
> --- a/src/exchangedb/pg_insert_kyc_attributes.c
> +++ b/src/exchangedb/pg_insert_kyc_attributes.c
> @@ -53,7 +53,7 @@ TEH_PG_insert_kyc_attributes (
>       .h_payto = *h_payto
>     };
>     char *kyc_completed_notify_s
> -    = GNUNET_PQ_get_event_notify_channel (&rep.header);
> +    = GNUNET_PG_get_event_notify_channel (&rep.header);
>     struct GNUNET_PQ_QueryParam params[] = {
>       GNUNET_PQ_query_param_uint64 (&process_row),
>       GNUNET_PQ_query_param_auto_from_type (h_payto),
> diff --git a/src/exchangedb/pg_reserves_in_insert.c 
> b/src/exchangedb/pg_reserves_in_insert.c
> index 21734942a..17cb496bf 100644
> --- a/src/exchangedb/pg_reserves_in_insert.c
> +++ b/src/exchangedb/pg_reserves_in_insert.c
> @@ -51,7 +51,7 @@ compute_notify_on_reserve (const struct 
> TALER_ReservePublicKeyP *reserve_pub)
>       .reserve_pub = *reserve_pub
>     };
>
> -  return GNUNET_PQ_get_event_notify_channel (&rep.header);
> +  return GNUNET_PG_get_event_notify_channel (&rep.header);
>   }