speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] Refactor module loading for single place of exec* call.


From: Trevor Saunders
Subject: [PATCH 1/2] Refactor module loading for single place of exec* call.
Date: Sat, 19 Mar 2011 18:02:00 -0400

On Sat, Mar 19, 2011 at 10:51:16PM +0100, Boris Du?ek wrote:
> On Mar 19, 2011, at 4:32 PM, Trevor Saunders wrote:
> 
> >> +          exit(1);
> >>            assert(0);
> > 
> > miner nit, some compilers will warn about that assert() being
> > unreachable
> 
> you are right, will send a (hopefully final) patch set shortly

I think they're good, the only thing I'd worry about at all is the
second null getting passed to exec possibly being interpreted as the
enviroment variable vector, though I believe the man page says this
won't happen, so I think this patch is fine.

Trev

> 
> _______________________________________________
> Speechd mailing list
> Speechd at lists.freebsoft.org
> http://lists.freebsoft.org/mailman/listinfo/speechd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20110319/bfddde35/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]