[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] rename spd_conv functions to spd_*
From: |
Trevor Saunders |
Subject: |
[PATCH 2/2] rename spd_conv functions to spd_* |
Date: |
Sat, 2 Oct 2010 02:25:15 -0400 |
Hi,
On Fri, Oct 01, 2010 at 12:40:09PM +0000, Andrei.Kholodnyi at gmail.com wrote:
> Hi Trev,
>
> are you fine with my argumentation?
Sorry I didn't get back to this sooner, I've been pretty busy for the
past month especially the past few days, and was just about Differing
all interupts.
ok, so here's what I think.
First I was using Williams definition of external being things clients
use, where clearly namespacing is needed. On the other hand only
modules that are external will see these functions, and I don't think
they need the same namespaceing since they really will have no need or
good reason that I can see to implement there own function with the same
name.
While I don't have any terrible problem with the prefixes I think
they're silly, waste peoples time when writing and reading them, and
don't tell you anything more about what the function does. I gues the
conv_ prefix is slightly useful in telling you its a convertion function
if the name x2y didn't already.
So if you really want to put these in the tree, fine whatever I just
think it will take up a little more of our time typing prefixes that
aren't useful and reading the same, so personally i wouldn't.
Trev
>
> Thanks,
> Andrei
> _______________________________________________
> Speechd mailing list
> Speechd at lists.freebsoft.org
> http://lists.freebsoft.org/mailman/listinfo/speechd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101002/433daa29/attachment.pgp>