Re: [Sks-devel] [PATCH] add fingerprint line to machine readable output

[John Clizbe]

Stefan Tomanek wrote:
> With this change, an additional line is appended to each search result when
> using the machine readable output. This line is prefixed with "fpr:" and
> contains the fingerprint of the key returned, making it possible to 
> distinguish
> keys from each other before downloading them - even if a key id collision has
> occured.
> 
> Signed-off-by: Stefan Tomanek <address@hidden>
> ---

A few questions:

1) It doesn't appear you checked the need for this patch against the current
trunk source, changelog, commit history, or any server running 1.1.4+. What
did you use as your source for SKS?

2) As Christoph has already pointed out, this breaks the draft we try to
follow as our standard. What benefit does this change give? Especially when
you consider...

3) Why do you need a SECOND fingerprint on a separate line? The one on the
pub: line isn't sufficient?

http://keyserver.gingerbear.net:11371/pks/lookup?search=Stefan+Tomanek&op=index&options=mr

https://bitbucket.org/skskeyserver/sks-keyserver/commits/f187022f7583c56216ca5871c56b0639ad837481
2012-10-27: Fixes for machine-readable indices.

Key expiration times are now read from self-signatures on the key's UIDs. (KF)
In addition, instead of 8-digit key IDs, index entries now return the most
specific key ID possible: 16-digit key ID for V3 keys, and the
full fingerprint for V4 keys. (JPC)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

-- 
John P. Clizbe                      Inet: John (a) Gingerbear DAWT net
SKS/Enigmail/PGP-EKP                  or: John ( @ ) Enigmail DAWT net
FSF Assoc #995 / FSFE Fellow #1797  hkp://keyserver.gingerbear.net  or
     mailto:address@hidden

Q:"Just how do the residents of Haiku, Hawai'i hold conversations?"
A:"An odd melody / island voices on the winds / surplus of vowels"

signature.asc
Description: OpenPGP digital signature