Re: sed+windows/cygwin+newlines: improving documentation

[Assaf Gordon]

Hello,

Attached updated patch.

On 18/10/18 04:03 PM, Eric Blake wrote:
> On 10/18/18 4:59 PM, Assaf Gordon wrote:
> > Hello,
> >
> >
> > Attached a patch to apply -b/--binary to STDIN/STDOUT under
> > windows/mingw.
> >
> > +++ b/doc/sed.texi
>
> Modern Cygwin still has the concept of text files, which have \r\n line 
> endings. It is just that you have to specifically request them via mount 
> options (they are not default).  So I don't think that excluding Cygwin 
> is correct here.

OK, I discarded the change.
I still cygwin usage under cygwin is not trivial with regards to 
binary/textmode,
but I'll leave it for a future doc patch.

> Isn't there a gnulib module for requesting setmode in a more portable 
> manner?

Good catch.
The new patch uses it.

Thanks!
 - assaf

0001-sed-fix-b-binary-mode-under-windows-mingw.patch
Description: Text Data