[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'make clean' removes *.po with unintended consequences

From: Jim Meyering
Subject: Re: 'make clean' removes *.po with unintended consequences
Date: Sat, 20 Aug 2016 20:17:53 -0700

On Sat, Aug 20, 2016 at 7:33 PM, Assaf Gordon <address@hidden> wrote:
> Hello Jim,
> I suspect commit 5b44cd0 ( "build: fix sed.1 dependency; work with latest 
> automake" ) had unintended consequences due to this:
>   +# This is a kludge to remove lib/.deps/{getfilecon,obstack}.Po,
>   +# which are left behind by bleeding edge automake.
>   +# Without this, 'make distcheck's final comparison would fail.
>   +MOSTLYCLEANFILES += lib/.deps/*.Po
> It seems running "make clean" in the source directory (not related to 'make 
> distcheck') leaves the makefiles broken, requiring a new "./configure" run.
> Example:
>     $ ./configure  # works
>     $ make         # works
>     $ make clean   # works
>     $ make
>     Makefile:2523: lib/.deps/alloca.Po: No such file or directory
>     Makefile:2524: lib/.deps/lib_libsed_a-acl-errno-valid.Po: No such file or 
> directory
>     Makefile:2525: lib/.deps/lib_libsed_a-acl-internal.Po: No such file or 
> directory
>     Makefile:2526: lib/.deps/lib_libsed_a-acl_entries.Po: No such file or 
> directory
>     Makefile:2527: lib/.deps/lib_libsed_a-alloca.Po: No such file or directory
>     ...
>     make: *** No rule to make target 'lib/.deps/lib_libsed_a-xmalloc.Po'.  
> Stop.
> >From there on, neither 'make' nor 'make clean' work, and re-running 
> >'./configure' is required.
> This reproducible on both Mac OS X and Debian.
> Not sure what's the best way to solve it while still removing the "Po" files.

Thanks for noticing.
"MOSTLYCLEANFILES" was not the right place to be removing those files.
The attached patch fixes it by removing the .deps directories only
while running distclean rules:

Attachment: distclean-check.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]