[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] sed: remove obsolete advice from --help output

From: Jim Meyering
Subject: Re: [PATCH] sed: remove obsolete advice from --help output
Date: Sun, 14 Aug 2016 18:36:15 -0700

On Sun, Aug 14, 2016 at 5:49 PM, Assaf Gordon <address@hidden> wrote:
>> On Aug 14, 2016, at 19:32, Jim Meyering <address@hidden> wrote:
>> While preparing the attached patch, I discovered a missing dependency bug.
>> To demonstrate, run "touch sed/sed.c; rm -f sed/sed; make", and witness this:
>> [...]
>> <sed-remove-obsolete-help-advice.diff>
> Good catch!
> A minor nit: a space before the parenthesis?
> +    fprintf(out, _("E-mail bug reports to: <%s>.\n"), PACKAGE_BUGREPORT);

Thank you for the speedy review.
This code is rather dirty in that respect (there are *many* such
violations), so I think it will be better to convert them en-masse,
once things settle down.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]