[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 6 small maintenance patches
From: |
Jim Meyering |
Subject: |
Re: 6 small maintenance patches |
Date: |
Sat, 30 Jul 2016 08:15:18 -0700 |
On Tue, Jul 26, 2016 at 8:00 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>
>> On Jul 26, 2016, at 01:41, Jim Meyering <address@hidden> wrote:
>>
>> On Mon, Jul 25, 2016 at 9:25 PM, Assaf Gordon <address@hidden> wrote:
>>>
>>> Assaf Gordon (4):
>>> maint: update .gitignore
>>> maint: update .gitignore after bootstrap
>>> maint: add copyright/license information to configure.ac
>>> maint: add static-analysis target to cfg.mk
>>
>> Thanks.
>> I've just pushed the first two.
>> Your patches look fine, modulo one style nit in two rules of your
>> Makefile.am change:
>>
>> +static-analysis-init:
>> + type scan-build 1>/dev/null 2>&1 || \
>> + { echo "scan-build program not found" >&2 ; exit 1 ;}
>>
>> Just as in C code, in bourne shell scripts, I prefer to leave space
>> after the semicolon, not before it.
>
> Attached updated patch.
Oh. Thanks. You're welcome to push that.