[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests: test -i/--inplace with backup suffix option

From: Jim Meyering
Subject: Re: tests: test -i/--inplace with backup suffix option
Date: Tue, 31 May 2016 08:29:38 -0700

On Sun, May 29, 2016 at 10:28 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
> Attached are improved (and expanded) tests.
> Fixed the 'tty' issue, and quoted here-docs.
> The tests should now cover most of the 'compile.c' file (without multibyte 
> sections).
> Also, attached four small changes to sed itself:
> * sed: allow multiple (non-conflicting) -E/-r parameters
> * sed: adjust line-ending of F/l/= commands with -z
> * sed: reject 's///e' in --posix mode
> * sed: standardize exit code values
> These might be a bit more controversial, so can be put for later...

Thank you for all of those tests.
So far, I like them a lot and the only change I request is to remove
the envvar settings like these that would end up being in nearly every
test script:

export LC_ALL=C

Instead, I propose the attached patch (intended to be applied before
your test additions), that adds the envvar-check file, as used in grep
and coreutils, along with adjustments to use that new

Attachment: 0001-tests-don-t-let-any-envvar-setting-perturb-tests.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]