Re: [screen-devel] Simple patch for double -U issue

[Clark Wang]

Hi Alex,

On Mon, Jan 24, 2022 at 2:18 AM Alex Naumov <alexander_naumov@opensuse.org> wrote:

Hi Clark,

thanks for reporting, but can you be a bit more verbose? :)

What does it mean "did not work"? Did you debug the value of nwin_options.encoding? What value does it have?
As you can see, It should be UTF8 in case of -1 and it should be -1 (as defined in nwin_undef struct in window.c).

Cheers,

Alex

On Mon, Nov 8, 2021 at 9:25 AM Clark Wang <dearvoid@gmail.com> wrote:

Hi,

I found a small issue where multiple -U options did not work. The
following patch fixed it for me. Just FYI.

-clark



diff --git a/src/screen.c b/src/screen.c
index f25f7fb..8aa3a1a 100644
--- a/src/screen.c
+++ b/src/screen.c
@@ -793,7 +793,7 @@ int main(int ac, char** av)

 #ifdef UTF8
           case 'U':
-            nwin_options.encoding = nwin_options.encoding == -1 ? UTF8 : 0;
+            nwin_options.encoding = UTF8;
             break;
 #endif

Just see the code. When nwin_options.encoding == -1, the 1st "-U" would set nwin_options.encoding=UTF8 and the 2nd "-U" would set nwin_options.encoding=0.

You can try like this:

  $ LC_ALL=C screen -U -U

-clark