[screen-devel] Fix for Makefile dependencies not in screen-v4 branch

[thomas . gambier]

Hello,

I am a developer at Nexedi and we are compiling screen very often in our 
test suites.

From time to time, we can't compile screen v4.8.0 because of the 
following error:


gcc -c -I. -I.  
-DETCSCREENRC='"/srv/slapgrid/slappart12/srv/testnode/csj/soft/801716244b0e4bd7e1418c588e9fb878/parts/screen/etc/screenrc"' 
-DSCREENENCODINGS='"/srv/slapgrid/slappart12/srv/testnode/csj/soft/801716244b0e4bd7e1418c588e9fb878/parts/screen/share/screen/utf8encodings"' 
-DHAVE_CONFIG_H -DGIT_REV=\"\" \
     
-I/srv/slapgrid/slappart12/srv/testnode/csj/soft/801716244b0e4bd7e1418c588e9fb878/parts/ncurses/include 
-D_GNU_SOURCE list_display.c
In file included from list_display.c:36:0:
screen.h:48:18: fatal error: comm.h: No such file or directory
  #include "comm.h"
                  ^
compilation terminated.
Makefile:82: recipe for target 'list_display.o' failed
make: *** [list_display.o] Error 1



This is because comm.h is not a dependency of list_display.c in 
Makefile.in. This has been fixed a long time ago on master branch : 
https://git.savannah.gnu.org/cgit/screen.git/commit/?id=84092e65f95dd2a00aa4cc2ba75682297f33dfea 
but it was never ported on screen-v4 branch.

Is there a reason for this ? Should I open a bug ?

Thank you very much.

Regards.

Thomas.

PS: I'm not subscribed to the list so please keep me in CC.