screen-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[screen-devel] [bug #37206] Support for newer terminal mouse modes


From: Amadeusz Sławiński
Subject: [screen-devel] [bug #37206] Support for newer terminal mouse modes
Date: Wed, 17 Jan 2018 19:01:31 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Update of bug #37206 (project screen):

             Assigned to:                    None => amade                  
         Planned Release:                    None => 4.7.0                  

    _______________________________________________________

Follow-up Comment #8:

Thanks for updated patch, I did some testing and it works great!

Some minor code nitpicks though:

(...)
+/* maximum mouse sequence length is SGR: ESC [ < b ; x ; y M */
+enum { MAX_MOUSE_SEQUENCE = 3+10+1+10+1+10+1 };
+
(...)
I think that this one should just be a #define

(...)
+             /* verify the mouse code (0 and 1005 are always valid) */
(...)
Um... 1005? And where it does this verification, I only see code translating
coordinates after that. Looking at older patches seems like leftover comment
from previous versions of this patch.

But yeah, I guess I can just fix those when applying. ;)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37206>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]