Re: [screen-devel] [PATCH] handle pty device from different namespace

[Amadeusz Sławiński]

On Wed, 22 Mar 2017 18:16:52 +0100
Christian Brauner <address@hidden> wrote:

> Various programs that deal with namespaces will use pty devices that
> exist in another namespace. One obvious candiate are containers. So
> far ttyname() was incorrectly handling this case because the pts
> device stems from the host and thus cannot be found amongst the
> current namespace's /dev/pts/<n> entries. Serge Hallyn and I recently
> upstreamed patches to glibc that allow ttyname{_r}() to correctly
> handle this case. At a minimum, ttyname{_r}() will set errno to
> ENODEV in case it finds that the /dev/pts/<n> device that the symlink
> points to exists in another namespace. This commit will allow screen
> to handle this case and behave correctly in a container.
> 
> Signed-off-by: Christian Brauner <address@hidden>

Hi,

thanks for patch, pushed to screen-v4 and master.

Cheers,
Amadeusz