Re: [screen-devel] [bug #50089] Screen 4.5.0 doesn't build on SunOS

[Amadeusz Sławiński]

Hi,

you can also check os.h, it seems to have MAXPATHLEN definition, I
wonder if it can be used? Should probably be consolidated into one
define, depending on which solution you decide.

Amadeusz

> Hi Alex,
> 
> thanks for looking into this.
> 
> On Mon, Jan 30, 2017 at 11:08:53PM +0100, Alex Naumov wrote:
> > On Thu, Jan 19, 2017 at 2:04 PM, Axel Beckert
> > <address@hidden> wrote:  
> > > Of course it would be nice if this would be solved in a cleaner
> > > way for an official fix.  
> > 
> > Like this?
> > 
> > #ifndef PATH_MAX
> > # ifdef _POSIX_PATH_MAX
> > # define PATH_MAX _POSIX_PATH_MAX
> > # endif
> > #endif  
> 
> No, that's not what I had in mind. There is no such limit on Hurd, so
> IMHO the code shouldn't enforce one.
> 
> > Does GNU/Hurd know about _POSIX_PATH_MAX?  
> 
> It seems to, but that's just a little bit less ugly than what I did.
> 
> Please see
> https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html
> and
> https://www.gnu.org/software/hurd/hurd/porting/guidelines.html#PATH_MAX_tt_MAX_PATH_tt_MAXPATHL
> 
> The latter suggests to define PATH_MAX as NULL, but there might be
> some corner cases where it needs more than just using NULL, maybe some
> additional checks for the value of PATH_MAX or so.
> 
>               Kind regards, Axel