[screen-devel] [bug #45345] utmp.c requires utmp.h include under musl

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?45345>

                 Summary: utmp.c requires utmp.h include under musl
                 Project: GNU Screen
            Submitted by: None
            Submitted on: Mi 17 Jun 2015 21:20:37 UTC
                Category: Build/Install
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: Cur Dev Sources
           Fixed Release: None
         Planned Release: None
           Work Required: None

    _______________________________________________________

Details:

In order to be able to compile screen in a musl libc toolchain we need to
patch src/utmp.c to include "os.h" which takes care of properly including
utmp.h

Without the fix the compilation fails like this:

<pre>mips_mips32_gcc-4.8-linaro_musl-1.1.10/usr/include
-I/mnt/dl/slave/brcm63xx.smp/build/staging_dir/toolchain-mips_mips32_gcc-4.8-linaro_musl-1.1.10/include
 -DETCSCREENRC='"/etc/screenrc"'
-DSCREENENCODINGS='"/usr/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
             -Os -pipe -mno-branch-likely -mips32 -mtune=mips32 
-fno-caller-saves
-fhonour-copts -Wno-error=unused-but-set-variable -msoft-float -Wformat
-Werror=format-security -Wl,-z,now -Wl,-z,relro  -D_GNU_SOURCE utmp.c
utmp.c: In function 'getlogin':
utmp.c:850:15: error: storage size of 'u' isn't known
   struct utmp u;
               ^
utmp.c:860:38: error: invalid application of 'sizeof' to incomplete type
'struct utmp'
   while (read(fd, (char *)&u, sizeof(struct utmp)) == sizeof(struct utmp))
                                      ^</pre>



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mi 17 Jun 2015 21:20:37 UTC  Name: os-include.patch  Size: 171B   By:
None
Proposed patch
<http://savannah.gnu.org/bugs/download.php?file_id=34250>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45345>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/