[Savannah-dev] [Bug #435] incorrect "Old Value" at the patches changelog

[nobody]

=================== BUG #435: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=435&group_id=11

Changes by: Laurent Julliard <address@hidden>
Date: 2002-Jun-24 15:05 (Europe/Paris)

            What     | Removed                   | Added
---------------------------------------------------------------------------
            Category | Patch Mgr                 | Other
          Resolution | None                      | Fixed
              Status | Open                      | Closed
              Effort | 0.50                      | 3.50


------------------ Additional Follow-up Comments ----------------------------
In many PHP scripts Unix datetime stamp 0 means no date defined yet but was 
however shown as Epoch time (Jan 1st, 1970). A new function has been introduced 
in www/include/utils.php to format null date as '-' by default and it is now 
called all over the place.

It is now recommended to use format_date($sys_datefmt,...) in all PHP scripts 
instead of the former date($sys_datefmt,...)


Impacted Files:
See http://mail.gnu.org/pipermail/savannah-cvs/2002-June/000230.html



=================== BUG #435: FULL BUG SNAPSHOT ===================


Submitted by: ksoonson                  Project: Savannah                       
Submitted on: 2002-May-22 05:33
Category:  Other                        Severity:  3 - Ordinary                 
Priority:  Low                          Bug Group:  None                        
Resolution:  Fixed                      Assigned to:  ljulliar                  
Status:  Closed                         Effort:  3.50                           

Summary:  incorrect "Old Value" at the patches changelog

Original Submission:  The "Old Value" at the tracker item history is 
1970-01-01. 
Go to any patches item, and click the title, you can see its changelog at the 
bottom. There, the "Old Value" is set to 1970-01-01. 

For example, check out the following URL and see the changelog at the bottom. 

http://savannah.gnu.org/patch/?func=detailpatch&patch_id=274&group_id=259

Follow-up Comments
*******************

-------------------------------------------------------
Date: 2002-Jun-24 15:05             By: ljulliar
In many PHP scripts Unix datetime stamp 0 means no date defined yet but was 
however shown as Epoch time (Jan 1st, 1970). A new function has been introduced 
in www/include/utils.php to format null date as '-' by default and it is now 
called all over the place.

It is now recommended to use format_date($sys_datefmt,...) in all PHP scripts 
instead of the former date($sys_datefmt,...)


Impacted Files:
See http://mail.gnu.org/pipermail/savannah-cvs/2002-June/000230.html

-------------------------------------------------------
Date: 2002-May-23 19:06             By: ljulliar
Well actually it's not yet fixed. It's just that I know where the problem is 
coming from. I have others and more urgent things to work on for the moment. 
But this will eventually be fized

-------------------------------------------------------
Date: 2002-May-23 08:51             By: ksoonson
Hmmm...it seems that you fixed this very quickly. :-)

Could you please let me know which part on what file did you modified so that I 
can apply it to debian-sf (http://savannah.gnu.org/projects/debian-sf/)

Thanks very much...

-------------------------------------------------------
Date: 2002-May-22 08:15             By: ljulliar
Thanks for pointing this out. What you see is actually the translation of the 
so called Unix epoch time since the beginning of Unix "history". This internal 
time is "0" and translate to Jan 1st, 1970.

So internally Unix time "0" is considered as "no value" and you are right that 
it should display as "None" or some special character like "-" to say that no 
value was previously assigned. This affects all Changelog not only patches but 
also in bugs, tasks and Support request.






No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=435&group_id=11