[Savannah-cvs] [716] Error handling improvements

[iank]

Revision: 716
          
http://svn.savannah.gnu.org/viewvc/?view=rev&root=administration&revision=716
Author:   iank
Date:     2023-12-13 16:40:28 -0500 (Wed, 13 Dec 2023)
Log Message:
-----------
Error handling improvements

Remove best effort error example. I found it used in fai, but on
reflection, I don't think it was a good use there, and it is probably
almost never a good use.

Improve manual error handling example so it captures error code.

Modified Paths:
--------------
    trunk/sviki/fsf/bash-style-guide.mdwn

Modified: trunk/sviki/fsf/bash-style-guide.mdwn
===================================================================
--- trunk/sviki/fsf/bash-style-guide.mdwn       2023-12-13 21:40:22 UTC (rev 
715)
+++ trunk/sviki/fsf/bash-style-guide.mdwn       2023-12-13 21:40:28 UTC (rev 
716)
@@ -376,26 +376,15 @@
 Manual error handling example:
 
 ```
-iptables -D $rule
-if [[ $? != [01] ]]; then
-  err-exit exiting due to failed iptables
+ret=0
+iptables -D $rule || ret=$?
+if [[ $ret != [01] ]]; then
+  err-exit exiting due to iptables failure with exit code: $ret
 fi
 ```
 
-If doing a best effort and not exiting on errors, the exit code should be
-the highest error.
+## Additional error handling notes:
 
-```
-error=0; trap 'error=$(($?>$error?$?:$error))' ERR
-# intentionally ignoring errors to do best effort
-command1
-command2
-command3
-exit $error
-```
-
-Additional error handling notes:
-
 In some circumstances pipefail may be too blunt. In that case, check
 `${PIPESTATUS[@]}`.