[task #15643] Add valgrind and patch to maneage

[Raul Infante-Sainz]

Follow-up Comment #3, task #15643 (project reproduce):

I tried but it didn't work. My laptop is a macOS High Sierra, v10.13.6. You
can have a look at the error in the attached file
`valgrind-crash-macOS.tar.gz'.

I also make some changes in order to try to fix it, but at the end it didn't
work. In short, I went to Homebrew formulae for installing valgrind in macOS
(https://github.com/Homebrew/homebrew-core/blob/master/Formula/valgrind.rb).
There, in the configure step there are some options:


   --disable-dependency-tracking
   --enable-only64bit
   --build=amd64-darwin


With these options, it also crashed. So, I investigated a bit more and it
seems that there are some hard coded paths into `coregrind/Makefile.in`, that
had to be replaced by the proper path for macOS systems (with Xcode). To
resume, I did the following changes (showed as Git diff):


diff --git a/reproduce/software/make/high-level.mk
b/reproduce/software/make/high-level.mk
index efaa3c6..14eab09 100644
--- a/reproduce/software/make/high-level.mk
+++ b/reproduce/software/make/high-level.mk
@@ -761,7 +761,8 @@ $(ibidir)/valgrind: $(ibidir)/patch \
             patch --verbose -p1 < $(patchdir)/valgrind-3.15.0-mpi-fix2.patch; \
           fi \
        && autoreconf \
-       && ./configure --prefix=$(idir) \
+       && sed -i
-e's|/usr/include/mach|/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/mach|g'
$(ddir)/valgrind-$(valgrind-version)/coregrind/Makefile.in \
+       && ./configure --prefix=$(idir) --disable-dependency-tracking
--enable-only64bit --build=amd64-darwin \
        && make -j$(numthreads) \
        && if ! make check -j$(numthreads); then \
             echo; echo "Valgrind's 'make check' failed!"; echo; \


But, again, it didn't work :-(((
At this point, I think if we want to merge with the master branch, we should
put a warning for noticing the user that Valgrind is not ready for macOS
systems yet. What do you think? I will try to fix this if I have time, but let
me know if you have any idea.

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/task/?15643>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/