[rdiff-backup-users] MAX_PATH / Windows

[Kuno Meyer]

Hi everybody

I've just run into the case that rdiff-backup does not properly handle 
path names longer than 260 chars on Windows (see stack trace below). As 
you may know, the Win32 API has some very strange corner cases with 
regard to long file names (see [1]).

In addition, the error cleanup handler seems to have issues as well, 
because 'rmdir' cannot remove non-empty directories (at least not on 
Windows)

Rdiff-backup version is 1.3.3.

Regards,
Kuno

[1] 
http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx#maxpath


C:/>F:\rdiff\admin\rdiff-backup.exe --exclude **/AppData/Local --exclude 
**/AppData/LocalLow Users F:/rdiff/kuno/c-users
Previous backup seems to have failed, regressing destination now.
UpdateError 
kuno/AppData/Roaming/LibreOffice/3/user/extensions/bundled/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/lu5d
gxnu.tmp/rdiff-backup.tmp.148 [Errno 2] No such file or directory: 
'F:/rdiff/kuno/c-users/rdiff-backup-data/increments/kuno/AppData/Roaming/LibreOffic
e/3/user/extensions/bundled/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/lu5dgxnu.tmp/SunPresentationMinimizer.xcu.2012-
11-29T23-34-24+01-00.missing'
UpdateError 
kuno/AppData/Roaming/LibreOffice/3/user/extensions/bundled/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/luo0
zk7y.tmp/rdiff-backup.tmp.238 [Errno 2] No such file or directory: 
'F:/rdiff/kuno/c-users/rdiff-backup-data/increments/kuno/AppData/Roaming/LibreOffic
e/3/user/extensions/bundled/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/luo0zk7y.tmp/SunPresentationMinimizer.xcu.2012-
11-29T23-34-24+01-00.snapshot.gz'
Exception '[Error 145] The directory is not empty: 
'F:/rdiff/kuno/c-users/kuno/AppData/Roaming/LibreOffice/3/user/extensions/bundled/registry/com.sun.
star.comp.deployment.configuration.PackageRegistryBackend/luo0zk7y.tmp'' 
raised of class '<type 'exceptions.WindowsError'>':
  File "rdiff_backup\Main.pyc", line 306, in error_check_Main
  File "rdiff_backup\Main.pyc", line 326, in Main
  File "rdiff_backup\Main.pyc", line 282, in take_action
  File "rdiff_backup\Main.pyc", line 345, in Backup
  File "rdiff_backup\backup.pyc", line 51, in Mirror_and_increment
  File "rdiff_backup\backup.pyc", line 251, in patch_and_increment
  File "rdiff_backup\rorpiter.pyc", line 277, in __call__
  File "rdiff_backup\rorpiter.pyc", line 229, in finish_branches
  File "rdiff_backup\backup.pyc", line 676, in end_process
  File "rdiff_backup\rpath.pyc", line 993, in rmdir

Traceback (most recent call last):
  File "rdiff-backup", line 30, in <module>
  File "rdiff_backup\Main.pyc", line 306, in error_check_Main
  File "rdiff_backup\Main.pyc", line 326, in Main
  File "rdiff_backup\Main.pyc", line 282, in take_action
  File "rdiff_backup\Main.pyc", line 345, in Backup
  File "rdiff_backup\backup.pyc", line 51, in Mirror_and_increment
  File "rdiff_backup\backup.pyc", line 251, in patch_and_increment
  File "rdiff_backup\rorpiter.pyc", line 277, in __call__
  File "rdiff_backup\rorpiter.pyc", line 229, in finish_branches
  File "rdiff_backup\backup.pyc", line 676, in end_process
  File "rdiff_backup\rpath.pyc", line 993, in rmdir
WindowsError: [Error 145] The directory is not empty: 
'F:/rdiff/kuno/c-users/kuno/AppData/Roaming/LibreOffice/3/user/extensions/bundled/registry/com.s
un.star.comp.deployment.configuration.PackageRegistryBackend/luo0zk7y.tmp'