Re: [rdiff-backup-users] [patch] rdiff-backup over encfs + sshfs fix

[dean gaudet]

On Thu, 30 Aug 2007, Jon Kolb wrote:

> Matthew Flaschen wrote:
> > Jon Kolb wrote:
> > > After poking around for a while, I discovered that on encfs/sshfs
> > > (or perhaps fuse in general), os.rename fails with "Operation not
> > > permitted" if the destination file already exists.
> > 
> > That sounds like a bug in one of fuse/encfs/sshfs.  I don't think it should
> > be worked around in rdiff-backup.
> 
> I'd tend to agree, but I figured that since this was an easy workaround,
> I'd post it anyway.

rename is atomic though, unlink+rename isn't.  we'd have to be sure that 
the atomic properties of rename aren't required in this segment of the 
code.

if we're going to hack around broken filesystems i'd prefer the code to 
first attempt a rename and if that fails with EEXIST then use the hack.

-dean