[Rdiff-backup-commits] rdiff-backup/rdiff_backup fs_abilities.py

[Andrew Ferguson]

CVSROOT:        /sources/rdiff-backup
Module name:    rdiff-backup
Changes by:     Andrew Ferguson <owsla> 07/12/25 01:42:53

Modified files:
        rdiff_backup   : fs_abilities.py 

Log message:
        We should FatalError at the point where the malformed UTF-8 character is
        first encountered, instead of catching it and then letting it cause more
        trouble down the road.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/rdiff-backup/rdiff_backup/fs_abilities.py?cvsroot=rdiff-backup&r1=1.40&r2=1.41

Patches:
Index: fs_abilities.py
===================================================================
RCS file: /sources/rdiff-backup/rdiff-backup/rdiff_backup/fs_abilities.py,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -b -r1.40 -r1.41
--- fs_abilities.py     15 Aug 2007 14:43:13 -0000      1.40
+++ fs_abilities.py     25 Dec 2007 01:42:53 -0000      1.41
@@ -227,11 +227,12 @@
                        except (IOError, OSError):
                                # Broken CIFS setups will sometimes create 
UTF-8 files
                                # and even stat them, but not let us perform 
file operations
-                               # on them. Test file will be deleted via 
shutil.rmtree()
-                               # when subdir is deleted. UTF-8 characters not 
in the
+                               # on them. Test file cannot be deleted. UTF-8 
chars not in the
                                # underlying codepage get translated to '?'
-                               self.extended_filenames = 0
-                       else:
+                               log.Log.FatalError("Could not delete extended 
filenames test "
+                                                                  "file. If 
you are using a CIFS share, please"
+                                                                  " see the 
FAQ entry about characters being "
+                                                                  "transformed 
to a '?'")
                                self.extended_filenames = 1
 
        def set_win_reserved_filenames(self, subdir):