[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH] Makefile.in: fix patch-wrapper checks
|
From: |
Jean Delvare |
|
Subject: |
Re: [Quilt-dev] [PATCH] Makefile.in: fix patch-wrapper checks |
|
Date: |
Wed, 04 Jun 2014 11:19:35 +0200 |
Le Tuesday 03 June 2014 à 14:07 +0200, Andreas Grünbacher a écrit :
> Kent,
>
> 2014-06-03 0:16 GMT+02:00 Kent R. Spillner <address@hidden>:
> > 293c4ddb added checks to Makefile.in to disable the patch-wrapper test
> > when the configure script is not invoked with the --with-patch-wrapper
> > argument. Those checks assumed that PATCH_WRAPPER will always be empty
> > unless --with-patch-wrapper was used. However, PATCH_WRAPPER will be
> > set to "no" when the configure script is invoked with the
> > --without-patch-wrapper argument.
Ah, my bad, I did not know that.
> ah, I see, thanks.
>
> > Add nested ifneq check to handle this case as well.
>
> There is a third use of PATCH_WRAPPER in the Makefile which this change
> doesn't
> handle, so let me fixing this bug in configure.ac instead.
Looks good. Thanks Andreas for the fix, and thanks Kent for the report!
--
Jean Delvare
SUSE L3 Support