[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi/block: Cosmetic change in BlockExportType schema
From: |
Eric Blake |
Subject: |
Re: [PATCH] qapi/block: Cosmetic change in BlockExportType schema |
Date: |
Fri, 28 Jan 2022 14:54:30 -0600 |
User-agent: |
NeoMutt/20211029-256-77b59a |
On Wed, Jan 19, 2022 at 01:14:39PM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daude <f4bug@amsat.org>
>
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
The doubled From: looks odd here. I'll double-check that git doesn't
mess up the actual commit once I apply the patch.
>
> Fix long line introduced in commit bb01ea73110 ("qapi/block:
> Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER").
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Acked-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> qapi/block-export.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-export.json b/qapi/block-export.json
> index f9ce79a974b..f183522d0d2 100644
> --- a/qapi/block-export.json
> +++ b/qapi/block-export.json
> @@ -278,7 +278,8 @@
> ##
> { 'enum': 'BlockExportType',
> 'data': [ 'nbd',
> - { 'name': 'vhost-user-blk', 'if': 'CONFIG_VHOST_USER_BLK_SERVER'
> },
> + { 'name': 'vhost-user-blk',
> + 'if': 'CONFIG_VHOST_USER_BLK_SERVER' },
> { 'name': 'fuse', 'if': 'CONFIG_FUSE' } ] }
Reviewed-by: Eric Blake <eblake@redhat.com>
Happy to queue this through my NBD tree (as it is tangentially related...)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org