[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/9] softmmu: Provide a clue as to why device tree loading failed
From: |
Laurent Vivier |
Subject: |
[PULL 5/9] softmmu: Provide a clue as to why device tree loading failed |
Date: |
Tue, 18 Jan 2022 13:28:43 +0100 |
From: Bernhard Beschow <shentey@gmail.com>
fdt_open_into() obligingly returns an error code in case the operation
failed. So be obliging as well and use it in the error message.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220116114649.40859-1-shentey@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
softmmu/device_tree.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/softmmu/device_tree.c b/softmmu/device_tree.c
index 3965c834ca62..31d106694048 100644
--- a/softmmu/device_tree.c
+++ b/softmmu/device_tree.c
@@ -60,7 +60,8 @@ void *create_device_tree(int *sizep)
}
ret = fdt_open_into(fdt, fdt, *sizep);
if (ret) {
- error_report("Unable to copy device tree in memory");
+ error_report("%s: Unable to copy device tree into memory: %s",
+ __func__, fdt_strerror(ret));
exit(1);
}
@@ -104,7 +105,8 @@ void *load_device_tree(const char *filename_path, int
*sizep)
ret = fdt_open_into(fdt, fdt, dt_size);
if (ret) {
- error_report("Unable to copy device tree in memory");
+ error_report("%s: Unable to copy device tree into memory: %s",
+ __func__, fdt_strerror(ret));
goto fail;
}
--
2.34.1
- [PULL 0/9] Trivial branch for 7.0 patches, Laurent Vivier, 2022/01/18
- [PULL 3/9] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ, Laurent Vivier, 2022/01/18
- [PULL 2/9] hw/scsi/megasas: Simplify using the ldst API, Laurent Vivier, 2022/01/18
- [PULL 4/9] tests: Fix typo in check-help output, Laurent Vivier, 2022/01/18
- [PULL 6/9] linux-user: Fix comment typo in arm cpu_loop code, Laurent Vivier, 2022/01/18
- [PULL 7/9] linux-user: Rename user_force_sig tracepoint to match function name, Laurent Vivier, 2022/01/18
- [PULL 9/9] linux-user: Remove MAX_SIGQUEUE_SIZE, Laurent Vivier, 2022/01/18
- [PULL 8/9] linux-user: Return void from queue_signal(), Laurent Vivier, 2022/01/18
- [PULL 1/9] hw/timer/etraxfs_timer: Add vmstate for ETRAX timers, Laurent Vivier, 2022/01/18
- [PULL 5/9] softmmu: Provide a clue as to why device tree loading failed,
Laurent Vivier <=
- Re: [PULL 0/9] Trivial branch for 7.0 patches, Peter Maydell, 2022/01/19