Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM)

[John Snow]

On Mon, Jan 17, 2022 at 3:02 AM Vladimir Sementsov-Ogievskiy
<vsementsov@virtuozzo.com> wrote:
>
> 10.01.2022 21:09, John Snow wrote:
> >
> >
> > On Mon, Jan 10, 2022 at 12:57 PM Stefan Weil <sw@weilnetz.de 
> > <mailto:sw@weilnetz.de>> wrote:
> >
> >     Am 10.01.22 um 18:08 schrieb John Snow:
> >
> >>     On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de 
> >> <mailto:sw@weilnetz.de>> wrote:
> >>
> >>         Signed-off-by: Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>>
> >>         ---
> >>          scripts/simplebench/bench-example.py | 2 +-
> >>          1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>         diff --git a/scripts/simplebench/bench-example.py 
> >> b/scripts/simplebench/bench-example.py
> >>         index 4864435f39..fc370691e0 100644
> >>         --- a/scripts/simplebench/bench-example.py
> >>         +++ b/scripts/simplebench/bench-example.py
> >>         @@ -25,7 +25,7 @@
> >>
> >>          def bench_func(env, case):
> >>              """ Handle one "cell" of benchmarking table. """
> >>         -    return bench_block_copy(env['qemu_binary'], env['cmd'], {}
> >>         +    return bench_block_copy(env['qemu_binary'], env['cmd'], {},
> >>                                      case['source'], case['target'])
> >>
> >>
> >>         --
> >>         2.30.2
> >>
> >>
> >>     Good spot. If it's not too late and not a hassle, can you add a fixes: 
> >> commit-id in the commit message? No big deal if not.
> >>
> >>     Reviewed-by: John Snow <jsnow@redhat.com <mailto:jsnow@redhat.com>>
> >
> >
> >     Maybe that can be added locally to avoid a V2 patch. Here it is:
> >
> >     Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd
> >
> >     Thanks,
> >
> >     Stefan
> >
> >
> > Got it. I just got back from holiday today, so there's still lots of mail 
> > to catch up on. If nobody else has staged this, I will do so as part of my 
> > python fixes this week. Thanks!
> >
>
> It would be nice, thanks!
>

Should be in origin/master by now, I forgot to update this thread.

--js