On 10/19/21 9:44 AM, Warner Losh wrote:
> +#define TARGET_INSN_SIZE 4 /* arm instruction size */
What is this for? arm max insn size?
It's used a few lines below:
+#define TARGET_SZSIGCODE ((abi_ulong)(9 * TARGET_INSN_SIZE))
which is a fancy way of getting the sizeof the sigtramp handler that's copied onto the stack and used in the setup.
It's then used in bsd-user/arm/target_arch_signal.h because it doesn't have visibility to target_arch_sigtramp.h's
namespace to get the size.
It's likely a 'todo' cleanup to make this less hard-coded.
Warner
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~