Re: [PATCH] target/i386: Include 'hw/i386/apic.h' locally

[Philippe Mathieu-Daudé]

On 9/29/21 17:16, Laurent Vivier wrote:
> Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
>> Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
>>> On 9/16/21 00:05, Paolo Bonzini wrote:
>>>> On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
>>>>> Instead of including a sysemu-specific header in "cpu.h"
>>>>> (which is shared with user-mode emulations), include it
>>>>> locally when required.
>>>>>
>>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>>> ---
>>>>
>>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>> Thank you, Cc'ing qemu-trivial@ :)
>>>
>>
>> Applied to my trivial-patches branch.
>>
> 
> We have a problem:
> 
> .../target/i386/tcg/sysemu/seg_helper.c:145:9: error: implicit declaration of 
> function
> 'apic_poll_irq' [-Werror=implicit-function-declaration]
>   145 |         apic_poll_irq(cpu->apic_state);
>       |         ^~~~~~~~~~~~~
> .../target/i386/tcg/sysemu/seg_helper.c:145:9: error: nested extern 
> declaration of 'apic_poll_irq'
> [-Werror=nested-externs]

Hmm I'll check what changed since I sent that. It was working the day
Paolo Acked, because have the patch rebased / tested on top of commit
c99e34e537f ("Merge remote-tracking branch
'remotes/vivier2/tags/linux-user-for-6.2-pull-request' into staging").

I should have rebased/retested today before Cc'ing you, sorry.